[PATCH drm-misc-next] drm: verisilicon: fix build failure of cursor plane code

[PATCH drm-misc-next] drm: verisilicon: fix build failure of cursor plane code

[Icenowy Zheng]

The cursor plane patch was stalled for a too long time that the
struct drm_atomic_state parameter of atomic modeset hooks has been
changed to struct drm_atomic_commit.

Fix this by replacing the parameter's type. All helpers that retrieve
information from this struct are also changed so simply replacing the
type works.

Fixes: 8c4ae2189125 ("drm: verisilicon: add support for cursor planes")
Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
---
 drivers/gpu/drm/verisilicon/vs_cursor_plane.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/verisilicon/vs_cursor_plane.c b/drivers/gpu/drm/verisilicon/vs_cursor_plane.c
index acb9854fa67ed..fa4f601dd0c87 100644
--- a/drivers/gpu/drm/verisilicon/vs_cursor_plane.c
+++ b/drivers/gpu/drm/verisilicon/vs_cursor_plane.c
@@ -40,7 +40,7 @@ static bool vs_cursor_plane_check_coord(int32_t coord)
 }
 
 static int vs_cursor_plane_atomic_check(struct drm_plane *plane,
-					struct drm_atomic_state *state)
+					struct drm_atomic_commit *state)
 {
 	struct drm_plane_state *new_plane_state = drm_atomic_get_new_plane_state(state,
 										 plane);
@@ -98,7 +98,7 @@ static void vs_cursor_plane_commit(struct vs_dc *dc, unsigned int output)
 }
 
 static void vs_cursor_plane_atomic_enable(struct drm_plane *plane,
-					   struct drm_atomic_state *atomic_state)
+					   struct drm_atomic_commit *atomic_state)
 {
 	struct drm_plane_state *state = drm_atomic_get_new_plane_state(atomic_state,
 								       plane);
@@ -115,7 +115,7 @@ static void vs_cursor_plane_atomic_enable(struct drm_plane *plane,
 }
 
 static void vs_cursor_plane_atomic_disable(struct drm_plane *plane,
-					    struct drm_atomic_state *atomic_state)
+					    struct drm_atomic_commit *atomic_state)
 {
 	struct drm_plane_state *state = drm_atomic_get_old_plane_state(atomic_state,
 								       plane);
@@ -132,7 +132,7 @@ static void vs_cursor_plane_atomic_disable(struct drm_plane *plane,
 }
 
 static void vs_cursor_plane_atomic_update(struct drm_plane *plane,
-					   struct drm_atomic_state *atomic_state)
+					   struct drm_atomic_commit *atomic_state)
 {
 	struct drm_plane_state *state = drm_atomic_get_new_plane_state(atomic_state,
 								       plane);
-- 
2.52.0

Claude review: drm: verisilicon: fix build failure of cursor plane code

[Claude Code Review Bot]

Patch Review

**Status: Looks good**

The patch changes the second parameter of four plane atomic hooks from `struct drm_atomic_state *` to `struct drm_atomic_commit *`:

1. `vs_cursor_plane_atomic_check` — confirmed matches vtable signature at `drm_modeset_helper_vtables.h:1311`
2. `vs_cursor_plane_atomic_enable` — confirmed matches vtable signature at `drm_modeset_helper_vtables.h:1353`
3. `vs_cursor_plane_atomic_disable` — confirmed matches vtable signature at `drm_modeset_helper_vtables.h:1378`
4. `vs_cursor_plane_atomic_update` — confirmed matches vtable signature at `drm_modeset_helper_vtables.h:1328`

All four functions pass `state`/`atomic_state` directly to `drm_atomic_get_new_plane_state()` or `drm_atomic_get_old_plane_state()`, both of which already take `const struct drm_atomic_commit *` (confirmed at `drm_atomic.h:824` and `drm_atomic.h:809`). So the type change is sufficient and no other code in the function bodies needs updating.

The commit message clearly explains the situation — the cursor plane patch was stalled long enough that the rename happened underneath it.

The `Fixes:` tag correctly references the commit that introduced the stale type.

No concerns with this patch.

---
Generated by Claude Code Patch Reviewer

Claude review: drm: verisilicon: fix build failure of cursor plane code

[Claude Code Review Bot]

Overall Series Review

Subject: drm: verisilicon: fix build failure of cursor plane code
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Patches: 1
Reviewed: 2026-05-26T06:48:27.508957

---

This is a single-patch fix for a build failure in the verisilicon cursor plane code. The `drm_atomic_state` struct was renamed to `drm_atomic_commit` in the DRM core, and the verisilicon cursor plane patch (commit `8c4ae2189125`) wasn't updated to follow suit. The fix is straightforward and correct — it mechanically replaces the type in all four function signatures where it appears. All callers (`drm_atomic_get_new_plane_state`, `drm_atomic_get_old_plane_state`) already accept `const struct drm_atomic_commit *`, so no further changes are needed.

The verisilicon driver directory doesn't exist in the drm-next tree I have access to, which means the base commit `8c4ae2189125` ("drm: verisilicon: add support for cursor planes") is likely in drm-misc-next. This explains why the patches didn't apply cleanly to the reference tree.

**Verdict: The patch looks correct and complete. No issues found.**

---
Generated by Claude Code Patch Reviewer