Claude review: drm/probe-helper: Honour connector->force in drm_helper_probe_detect()

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Correctness: Good**

The early return at line 404-408 is placed before both code paths (`!ctx` and the locked path), so it covers all callers uniformly. The return value `connector_status_disconnected` is consistent with what `drm_helper_probe_single_connector_modes()` sets at line 600 for `DRM_FORCE_OFF`.

**Epoch counter behavior: Acceptable**

The early return bypasses the `epoch_counter` increment at line 419-420. This is fine because:
- For the initial boot probe, `connector->status` starts as `connector_status_unknown`, so the first call returning `connector_status_disconnected` would trigger an epoch bump in the `!ctx` path (via `drm_helper_probe_detect_ctx` at line 377-378). However, with this patch the early return skips that bump. In practice, this is a non-issue: the polling path at line 795 already skips forced connectors entirely (`if (connector->force) continue`), and `drm_helper_probe_single_connector_modes()` at line 595 handles forced connectors before calling `drm_helper_probe_detect()`.
- The i915 caller at `intel_hotplug.c:322` checks `old_epoch_counter != connector->base.epoch_counter` at line 326, but since the connector is forced off, no epoch change is expected and `INTEL_HOTPLUG_UNCHANGED` will be returned, which is the correct result.

**One minor observation on callers:**

The `drm_helper_hpd_irq_event()` caller at line 994 does `connector->status = drm_helper_probe_detect(...)` unconditionally (no `!connector->force` guard like i915 has at line 323). With this patch, a forced-off connector receiving an HPD IRQ would now get `connector_status_disconnected` assigned directly, which is the correct status for a forced-off connector. Previously it would have run the full detect and potentially set `connector_status_connected`, which would then be overridden later by `drm_helper_probe_single_connector_modes()`. So this is actually a slight improvement for that path too.

**Style: Clean**

The debug message format `[CONNECTOR:%d:%s] forced off, skipping detect` follows the existing DRM debug conventions in the file.

**Commit message: Well-written**

Clear problem description, explicit rationale for why `DRM_FORCE_ON`/`DRM_FORCE_ON_DIGITAL` are not short-circuited, and includes test evidence. The version history is helpful.

**Minor nit (non-blocking):** The commit message has a missing closing backtick on the test command line:
```
With `video=DP-2:d drm.debug=0x04, Linux logs:
```
should be:
```
With `video=DP-2:d drm.debug=0x04`, Linux logs:
```

**Verdict: Reviewed-by worthy.** The patch is correct, minimal, and well-explained.

---
Generated by Claude Code Patch Reviewer