From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/probe-helper: Honour connector->force in drm_helper_probe_detect()
Date: Wed, 27 May 2026 13:57:30 +1000 [thread overview]
Message-ID: <review-overall-20260526223203.42982-2-pmenzel@molgen.mpg.de> (raw)
In-Reply-To: <20260526223203.42982-2-pmenzel@molgen.mpg.de>
Overall Series Review
Subject: drm/probe-helper: Honour connector->force in drm_helper_probe_detect()
Author: Paul Menzel <pmenzel@molgen.mpg.de>
Patches: 1
Reviewed: 2026-05-27T13:57:30.178462
---
This is a single well-motivated patch that fixes a real behavioral gap in the DRM probe helper infrastructure. The problem is clear: `drm_helper_probe_single_connector_modes()` (line 595) already respects `connector->force` and skips hardware detection when a connector is forced, but `drm_helper_probe_detect()` does not. Callers that go through `drm_helper_probe_detect()` directly — most notably i915's `intel_hotplug_detect_connector()` — perform unnecessary hardware probes (AUX/DPCD reads, DDC transactions) on connectors the user has explicitly forced off via `video=`.
The fix is minimal, correct in scope, and well-placed. The decision to only short-circuit `DRM_FORCE_OFF` (and not `DRM_FORCE_ON` / `DRM_FORCE_ON_DIGITAL`) is well-reasoned and explicitly documented in the commit message.
**Recommendation: Looks good to merge.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-27 3:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 22:32 [PATCH v3] drm/probe-helper: Honour connector->force in drm_helper_probe_detect() Paul Menzel
2026-05-27 3:57 ` Claude review: " Claude Code Review Bot
2026-05-27 3:57 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 19:18 [PATCH v2] drm/probe-helper: honour " Paul Menzel
2026-05-27 4:18 ` Claude review: " Claude Code Review Bot
2026-05-27 4:18 ` Claude Code Review Bot
2026-05-26 15:20 [PATCH] " Paul Menzel
2026-05-27 4:37 ` Claude review: " Claude Code Review Bot
2026-05-27 4:37 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260526223203.42982-2-pmenzel@molgen.mpg.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox