From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/probe-helper: honour connector->force in drm_helper_probe_detect()
Date: Wed, 27 May 2026 14:37:43 +1000 [thread overview]
Message-ID: <review-overall-20260526152025.12530-2-pmenzel@molgen.mpg.de> (raw)
In-Reply-To: <20260526152025.12530-2-pmenzel@molgen.mpg.de>
Overall Series Review
Subject: drm/probe-helper: honour connector->force in drm_helper_probe_detect()
Author: Paul Menzel <pmenzel@molgen.mpg.de>
Patches: 2
Reviewed: 2026-05-27T14:37:43.812300
---
This is a single-patch fix for a real and well-identified issue: `video=<connector>:d` on the kernel command line correctly sets `connector->force` at init time, but `drm_helper_probe_detect()` has no guard for it. This means callers like i915's `intel_hotplug_detect_connector()` (which goes through `check_connector_changed()` → `drm_helper_probe_detect()`) still run a full hardware probe on forced-off connectors.
The fix is the right approach — it mirrors the existing pattern in `drm_helper_probe_single_connector_modes()` (line 589) and the existing `connector->force` skip in `output_poll_execute()` (line 789). The commit message is well-written with good motivation and test evidence.
There are a couple of concerns worth raising.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-27 4:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 15:20 [PATCH] drm/probe-helper: honour connector->force in drm_helper_probe_detect() Paul Menzel
2026-05-26 16:58 ` Jani Nikula
2026-05-27 4:37 ` Claude Code Review Bot [this message]
2026-05-27 4:37 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 19:18 [PATCH v2] " Paul Menzel
2026-05-27 4:18 ` Claude review: " Claude Code Review Bot
2026-05-27 4:18 ` Claude Code Review Bot
2026-05-26 22:32 [PATCH v3] drm/probe-helper: Honour " Paul Menzel
2026-05-27 3:57 ` Claude review: " Claude Code Review Bot
2026-05-27 3:57 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260526152025.12530-2-pmenzel@molgen.mpg.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox