From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: dsi: Add maximum per lane bit rate calculation
Date: Thu, 04 Jun 2026 11:57:42 +1000 [thread overview]
Message-ID: <review-patch1-20260603033532.164-2-kernel@airkyi.com> (raw)
In-Reply-To: <20260603033532.164-2-kernel@airkyi.com>
Patch Review
**Status: Looks good overall**
This patch replaces the hard-coded max lane rate (previously derived from `dppa_map[ARRAY_SIZE(dppa_map) - 1].max_mbps`, which was always 1500 Mbps) with a per-chip `max_bit_rate_per_lane` field. The values assigned per SoC are:
- PX30, RK3128, RV1126: 1000 Mbps (1000000000UL)
- RK3568: 1200 Mbps (1200000000UL)
- RK3288, RK3368, RK3399, RK3506: 1500 Mbps (1500000000UL)
The unit conversion is correct:
```c
max_mbps = dsi->cdata->max_bit_rate_per_lane / USEC_PER_SEC;
```
`USEC_PER_SEC` = 1,000,000, so e.g. 1,500,000,000 / 1,000,000 = 1500 Mbps. This is correct.
**Minor observation**: For chips that previously had a max of 1500 from `dppa_map`, this is a no-op. For PX30/RK3128/RV1126, this is now a *functional change* that lowers the max from 1500 to 1000 Mbps — this will cause the "out of range" error path to trigger earlier on those chips, which is actually the correct behavior since they can't actually drive 1500 Mbps.
No issues found in this patch.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 1:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 3:35 [PATCH v2 0/3] DSI Controller improvements for Rockchip platforms Chaoyi Chen
2026-06-03 3:35 ` [PATCH v2 1/3] drm/rockchip: dsi: Add maximum per lane bit rate calculation Chaoyi Chen
2026-06-04 1:57 ` Claude Code Review Bot [this message]
2026-06-03 3:35 ` [PATCH v2 2/3] drm/rockchip: dsi: Add dphy_get_timing support for multiple PHY types Chaoyi Chen
2026-06-04 1:57 ` Claude review: " Claude Code Review Bot
2026-06-03 3:35 ` [PATCH v2 3/3] drm/rockchip: dsi: Relax the lane rate margin requirements Chaoyi Chen
2026-06-04 1:57 ` Claude review: " Claude Code Review Bot
2026-06-04 1:57 ` Claude review: DSI Controller improvements for Rockchip platforms Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260603033532.164-2-kernel@airkyi.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox