From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched
Date: Tue, 05 May 2026 10:41:28 +1000 [thread overview]
Message-ID: <review-patch1-afNBJZOZSova0p22@ashevche-desk.local> (raw)
In-Reply-To: <afNBJZOZSova0p22@ashevche-desk.local>
Patch Review
**Correctness:** Confirmed. A grep of the full kernel tree shows `fbtft_write_gpio16_wr_latched` only appears in its definition (`fbtft-io.c:231`), its `EXPORT_SYMBOL` (`fbtft-io.c:236`), and its declaration (`fbtft.h:265`). There are zero callers.
**Patch is well-scoped:** It removes the function body and `EXPORT_SYMBOL` from `fbtft-io.c`, and removes the declaration from `fbtft.h`. Both hunks are clean deletions with no surrounding changes.
**Commit message:** Accurate and concise. Correctly notes the function is unreferenced and is a stub.
**Minor nit (informational only):** The removed stub returns `-1` rather than a proper negative errno like `-ENOSYS`. This is a pre-existing style issue that goes away with the removal, so no action needed — just reinforces that this dead code was never properly maintained.
**No issues. Patch is ready to apply.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-05 0:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 10:25 [PATCH] staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched Hungyu Lin
2026-04-30 11:46 ` Andy Shevchenko
2026-05-05 0:41 ` Claude review: " Claude Code Review Bot
2026-05-05 0:41 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-afNBJZOZSova0p22@ashevche-desk.local \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox