[PATCH] staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched

[PATCH] staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched

[Hungyu Lin]

The function fbtft_write_gpio16_wr_latched is not referenced anywhere
in the driver and only contains a stub implementation.

Remove it from the driver.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/staging/fbtft/fbtft-io.c | 7 -------
 drivers/staging/fbtft/fbtft.h    | 1 -
 2 files changed, 8 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
index de1904a443c2..7d331eba947a 100644
--- a/drivers/staging/fbtft/fbtft-io.c
+++ b/drivers/staging/fbtft/fbtft-io.c
@@ -227,10 +227,3 @@ int fbtft_write_gpio16_wr(struct fbtft_par *par, void *buf, size_t len)
 	return 0;
 }
 EXPORT_SYMBOL(fbtft_write_gpio16_wr);
-
-int fbtft_write_gpio16_wr_latched(struct fbtft_par *par, void *buf, size_t len)
-{
-	dev_err(par->info->device, "%s: function not implemented\n", __func__);
-	return -1;
-}
-EXPORT_SYMBOL(fbtft_write_gpio16_wr_latched);
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 317be17b95c1..c7afb0fd3943 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -262,7 +262,6 @@ int fbtft_write_spi_emulate_9(struct fbtft_par *par, void *buf, size_t len);
 int fbtft_read_spi(struct fbtft_par *par, void *buf, size_t len);
 int fbtft_write_gpio8_wr(struct fbtft_par *par, void *buf, size_t len);
 int fbtft_write_gpio16_wr(struct fbtft_par *par, void *buf, size_t len);
-int fbtft_write_gpio16_wr_latched(struct fbtft_par *par, void *buf, size_t len);
 
 /* fbtft-bus.c */
 int fbtft_write_vmem8_bus8(struct fbtft_par *par, size_t offset, size_t len);
-- 
2.34.1

Re: [PATCH] staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched

[Andy Shevchenko]

On Thu, Apr 30, 2026 at 10:25:29AM +0000, Hungyu Lin wrote:
> The function fbtft_write_gpio16_wr_latched is not referenced anywhere

fbtft_write_gpio16_wr_latched()

> in the driver and only contains a stub implementation.
> 
> Remove it from the driver.

Agree, pure code removal is always welcome.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>

-- 
With Best Regards,
Andy Shevchenko

Claude review: Re: [PATCH] staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched

[Claude Code Review Bot]

Overall Series Review

Subject: Re: [PATCH] staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched
Author: Andy Shevchenko <andriy.shevchenko@intel.com>
Patches: 2
Reviewed: 2026-05-05T10:41:28.167281

---

This is a single, straightforward cleanup patch that removes the dead function `fbtft_write_gpio16_wr_latched()` from the staging fbtft driver. The function is indeed unused: it has no callers anywhere in the kernel tree, and its body is just a stub that prints an error and returns `-1`. The patch is correct, complete, and well-formed.

**Verdict: Looks good.** No issues found.

---
Generated by Claude Code Patch Reviewer

Claude review: Re: [PATCH] staging: fbtft: remove unused function fbtft_write_gpio16_wr_latched

[Claude Code Review Bot]

Patch Review

**Correctness:** Confirmed. A grep of the full kernel tree shows `fbtft_write_gpio16_wr_latched` only appears in its definition (`fbtft-io.c:231`), its `EXPORT_SYMBOL` (`fbtft-io.c:236`), and its declaration (`fbtft.h:265`). There are zero callers.

**Patch is well-scoped:** It removes the function body and `EXPORT_SYMBOL` from `fbtft-io.c`, and removes the declaration from `fbtft.h`. Both hunks are clean deletions with no surrounding changes.

**Commit message:** Accurate and concise. Correctly notes the function is unreferenced and is a stub.

**Minor nit (informational only):** The removed stub returns `-1` rather than a proper negative errno like `-ENOSYS`. This is a pre-existing style issue that goes away with the removal, so no action needed — just reinforces that this dead code was never properly maintained.

**No issues. Patch is ready to apply.**

---
Generated by Claude Code Patch Reviewer