From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: boe-bf060y8m-aj0: use devm_drm_panel_add()
Date: Mon, 25 May 2026 16:58:17 +1000 [thread overview]
Message-ID: <review-patch1-f7407c121909b6da415d4b91f62669ea250a42de.1779640137.git.mhun512@gmail.com> (raw)
In-Reply-To: <f7407c121909b6da415d4b91f62669ea250a42de.1779640137.git.mhun512@gmail.com>
Patch Review
**Status: Good**
The change replaces:
```c
drm_panel_add(&boe->panel);
```
with:
```c
ret = devm_drm_panel_add(dev, &boe->panel);
if (ret)
return ret;
```
and removes `drm_panel_remove(&boe->panel)` from the `remove` callback.
This is correct. The `remove` callback is retained because this driver uses manual `mipi_dsi_attach()` (not `devm_mipi_dsi_attach()`), so it still needs its `mipi_dsi_detach()` call in `boe_bf060y8m_aj0_remove()`. The devres-managed panel removal will happen automatically after `remove()` returns.
**One minor observation**: The `boe_bf060y8m_aj0_remove()` callback now only does `mipi_dsi_detach()` with error reporting. This is fine as-is, but a potential follow-up could convert to `devm_mipi_dsi_attach()` and eliminate the `remove` callback entirely — though that's out of scope for this fix.
The error handling for `devm_drm_panel_add()` failure (returning the error code) is correct. No other cleanup is needed since all prior resource acquisitions in the probe function already use devres (`devm_gpiod_get`, `devm_drm_panel_alloc`, etc.).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 16:36 [PATCH 0/2] drm/panel: use devm_drm_panel_add() in more drivers Myeonghun Pak
2026-05-24 16:36 ` [PATCH 1/2] drm/panel: boe-bf060y8m-aj0: use devm_drm_panel_add() Myeonghun Pak
2026-05-25 6:58 ` Claude Code Review Bot [this message]
2026-05-24 16:36 ` [PATCH 2/2] drm/panel: novatek-nt36523: " Myeonghun Pak
2026-05-25 6:58 ` Claude review: " Claude Code Review Bot
2026-05-25 6:58 ` Claude review: drm/panel: use devm_drm_panel_add() in more drivers Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-f7407c121909b6da415d4b91f62669ea250a42de.1779640137.git.mhun512@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox