public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: novatek-nt36523: use devm_drm_panel_add()
Date: Mon, 25 May 2026 16:58:17 +1000	[thread overview]
Message-ID: <review-patch2-c6fe4a162692b4df5525353dbdac5b88eda91a79.1779640137.git.mhun512@gmail.com> (raw)
In-Reply-To: <c6fe4a162692b4df5525353dbdac5b88eda91a79.1779640137.git.mhun512@gmail.com>

Patch Review

**Status: Good**

The change replaces:
```c
drm_panel_add(&pinfo->panel);
```
with:
```c
ret = devm_drm_panel_add(dev, &pinfo->panel);
if (ret)
    return ret;
```

It also removes the entire `nt36523_remove()` callback and its `.remove` assignment in the driver struct. This is correct because `nt36523_probe()` uses `devm_mipi_dsi_attach()` for DSI attachment, so both DSI detach and panel removal are fully managed by devres. There is no remaining manual cleanup, so the remove callback is no longer needed.

The devres ordering is correct: `devm_drm_panel_add()` is registered before `devm_mipi_dsi_attach()`, so during teardown the DSI devices will be detached before the panel is removed from the registry. This is the right order — consumers (DSI hosts) should be disconnected before the panel disappears.

The `Fixes:` tag correctly points to commit `0993234a0045` which introduced the driver with the original `drm_panel_add()` call.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25  6:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-24 16:36 [PATCH 0/2] drm/panel: use devm_drm_panel_add() in more drivers Myeonghun Pak
2026-05-24 16:36 ` [PATCH 1/2] drm/panel: boe-bf060y8m-aj0: use devm_drm_panel_add() Myeonghun Pak
2026-05-25  6:58   ` Claude review: " Claude Code Review Bot
2026-05-24 16:36 ` [PATCH 2/2] drm/panel: novatek-nt36523: " Myeonghun Pak
2026-05-25  6:58   ` Claude Code Review Bot [this message]
2026-05-25  6:58 ` Claude review: drm/panel: use devm_drm_panel_add() in more drivers Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-c6fe4a162692b4df5525353dbdac5b88eda91a79.1779640137.git.mhun512@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox