From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: rockchip: dw-dp: fix sound DAI cells
Date: Tue, 05 May 2026 09:49:48 +1000 [thread overview]
Message-ID: <review-patch11-20260501-synopsys-dw-dp-improvements-v2-11-d7e7f6bac77f@collabora.com> (raw)
In-Reply-To: <20260501-synopsys-dw-dp-improvements-v2-11-d7e7f6bac77f@collabora.com>
Patch Review
Changes `#sound-dai-cells` from 0 to 1 to allow selecting I2S vs SPDIF.
**This is an ABI break** — existing DTs have `#sound-dai-cells = <0>` and references like `sound-dai = <&dp0>`. Changing to 1 cell means all existing sound references would need updating. The commit message discusses MST considerations well.
The `description: 0 for I2S, 1 for SPDIF` should be in the binding's description for the `#sound-dai-cells` property, not just as a bare description line. Also, since this is an existing ABI change, it needs more consideration about backwards compatibility (e.g., supporting both 0 and 1 cells in the driver).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 23:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-30 22:20 [PATCH v2 00/12] Synopsys DisplayPort Controller improvements for Rockchip platforms Sebastian Reichel
2026-04-30 22:20 ` [PATCH v2 01/12] drm/bridge: synopsys: dw-dp: Support unregistering the AUX channel Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 02/12] drm/rockchip: dw_dp: Release core resources Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 03/12] drm/bridge: synopsys: dw-dp: Simplify driver data setting Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 04/12] drm/bridge: synopsys: dw-dp: Support MEDIA_BUS_FMT_FIXED Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 05/12] drm/bridge: synopsys: dw-dp: Add follow-up bridge support Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 06/12] drm/bridge: Add out-of-band HPD notify handler Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 07/12] drm/rockchip: dw_dp: Implement out-of-band HPD handling Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 08/12] drm/bridge: synopsys: dw-dp: Support software triggered OOB HPD Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 09/12] drm/bridge: synopsys: dw-dp: Add Runtime PM support Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 10/12] drm/rockchip: dw_dp: Add runtime " Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH RFC v2 11/12] dt-bindings: display: rockchip: dw-dp: fix sound DAI cells Sebastian Reichel
2026-05-04 23:49 ` Claude Code Review Bot [this message]
2026-04-30 22:20 ` [PATCH v2 12/12] drm/bridge: synopsys: dw-dp: Add audio support Sebastian Reichel
2026-05-04 23:49 ` Claude review: " Claude Code Review Bot
2026-05-04 23:49 ` Claude review: Synopsys DisplayPort Controller improvements for Rockchip platforms Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch11-20260501-synopsys-dw-dp-improvements-v2-11-d7e7f6bac77f@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox