public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: Add out-of-band HPD notify handler
Date: Tue, 05 May 2026 09:49:47 +1000	[thread overview]
Message-ID: <review-patch6-20260501-synopsys-dw-dp-improvements-v2-6-d7e7f6bac77f@collabora.com> (raw)
In-Reply-To: <20260501-synopsys-dw-dp-improvements-v2-6-d7e7f6bac77f@collabora.com>

Patch Review

Adds a new `oob_notify` callback to `struct drm_bridge_funcs` and calls it from `drm_bridge_connector_oob_hotplug_event()` for every bridge in the chain.

```c
+	void (*oob_notify)(struct drm_bridge *bridge,
+			   struct drm_connector *connector,
+			   enum drm_connector_status status);
```

**Design question (acknowledged by author):** The cover letter mentions this might not be the ideal solution. The concern is valid — `oob_hotplug_event` already calls `drm_bridge_connector_handle_hpd()` which goes through `hpd_notify`. Having a separate `oob_notify` that fires before the existing `hpd_notify` flow creates two notification paths. The rationale (OOB needs to force HPD state before `.detect` runs) is sound, but this should be discussed with DRM bridge maintainers (Dmitry Baryshkov is already CC'd).

**Minor:** The iteration uses `drm_for_each_bridge_in_chain_scoped` which notifies *all* bridges, but only the DP controller bridge will actually implement `oob_notify`. This is fine — the callback check handles it.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-04 23:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-30 22:20 [PATCH v2 00/12] Synopsys DisplayPort Controller improvements for Rockchip platforms Sebastian Reichel
2026-04-30 22:20 ` [PATCH v2 01/12] drm/bridge: synopsys: dw-dp: Support unregistering the AUX channel Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 02/12] drm/rockchip: dw_dp: Release core resources Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 03/12] drm/bridge: synopsys: dw-dp: Simplify driver data setting Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 04/12] drm/bridge: synopsys: dw-dp: Support MEDIA_BUS_FMT_FIXED Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 05/12] drm/bridge: synopsys: dw-dp: Add follow-up bridge support Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 06/12] drm/bridge: Add out-of-band HPD notify handler Sebastian Reichel
2026-05-04 23:49   ` Claude Code Review Bot [this message]
2026-04-30 22:20 ` [PATCH v2 07/12] drm/rockchip: dw_dp: Implement out-of-band HPD handling Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 08/12] drm/bridge: synopsys: dw-dp: Support software triggered OOB HPD Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 09/12] drm/bridge: synopsys: dw-dp: Add Runtime PM support Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 10/12] drm/rockchip: dw_dp: Add runtime " Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH RFC v2 11/12] dt-bindings: display: rockchip: dw-dp: fix sound DAI cells Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-04-30 22:20 ` [PATCH v2 12/12] drm/bridge: synopsys: dw-dp: Add audio support Sebastian Reichel
2026-05-04 23:49   ` Claude review: " Claude Code Review Bot
2026-05-04 23:49 ` Claude review: Synopsys DisplayPort Controller improvements for Rockchip platforms Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch6-20260501-synopsys-dw-dp-improvements-v2-6-d7e7f6bac77f@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox