public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: analogix_dp: Add support for RK3576
Date: Thu, 04 Jun 2026 14:37:03 +1000	[thread overview]
Message-ID: <review-patch11-20260601065100.1103873-12-damon.ding@rock-chips.com> (raw)
In-Reply-To: <20260601065100.1103873-12-damon.ding@rock-chips.com>

Patch Review

Adds the platform chip_data and OF match entry:

```c
+static const struct rockchip_dp_chip_data rk3576_edp[] = {
+	{
+		.chip_type = RK3576_EDP,
+		.reg = 0x27dc0000,
+	},
+	{ /* sentinel */ }
+};
```

**Observation**: Unlike RK3588's chip_data which includes `.edp_mode = GRF_REG_FIELD(0x0000, 0, 0)`, the RK3576 entry has no `edp_mode` field. This means in `rockchip_dp_poweron()`, the call to `rockchip_grf_field_write(dp->grf, &dp->data->edp_mode, 1)` will be a no-op because `field->valid` is false (zero-initialized). This is safe due to the `valid` check, but it would be worth confirming whether RK3576 truly doesn't need an edp_mode GRF write for the video datapath, or if this is an oversight. The cover letter says "RK3576 integrates an eDP TX controller compatible with the existing RK3588 hardware design" which might suggest it should have one.

Similarly, the `lcdc_sel` field is not set, matching the RK3588 behavior (RK3588 also lacks `lcdc_sel`).

Has Reviewed-by from Nicolas Frattaroli and Luca Ceresoli.

No blocking issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  4:37 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01  6:50 [PATCH v10 00/11] Add eDP support for RK3576 Damon Ding
2026-06-01  6:50 ` [PATCH v10 01/11] dt-bindings: display: rockchip: analogix-dp: Fix hclk as third clock for RK3588 Damon Ding
2026-06-02 17:01   ` Conor Dooley
2026-06-04  4:37   ` Claude review: " Claude Code Review Bot
2026-06-01  6:50 ` [PATCH v10 02/11] dt-bindings: display: rockchip: analogix-dp: Add per-clock descriptions Damon Ding
2026-06-04  4:37   ` Claude review: " Claude Code Review Bot
2026-06-01  6:50 ` [PATCH v10 03/11] arm64: dts: rockchip: Add missing hclk for RK3588 eDP0 Damon Ding
2026-06-04  4:37   ` Claude review: " Claude Code Review Bot
2026-06-01  6:50 ` [PATCH v10 04/11] arm64: dts: rockchip: Add missing hclk for RK3588 eDP1 Damon Ding
2026-06-04  4:37   ` Claude review: " Claude Code Review Bot
2026-06-01  6:50 ` [PATCH v10 05/11] drm/rockchip: analogix_dp: Enable hclk for RK3588 Damon Ding
2026-06-04  4:37   ` Claude review: " Claude Code Review Bot
2026-06-01  6:50 ` [PATCH v10 06/11] drm/rockchip: analogix_dp: Fix OF node reference leak via auto cleanup Damon Ding
2026-06-04  4:37   ` Claude review: " Claude Code Review Bot
2026-06-01  6:50 ` [PATCH v10 07/11] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Damon Ding
2026-06-04  4:37   ` Claude review: " Claude Code Review Bot
2026-06-01  6:50 ` [PATCH v10 08/11] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-06-04  4:37   ` Claude review: " Claude Code Review Bot
2026-06-01  6:50 ` [PATCH v10 09/11] drm/bridge: analogix_dp: Rename and simplify is_rockchip() Damon Ding
2026-06-04  4:37   ` Claude review: " Claude Code Review Bot
2026-06-01  6:50 ` [PATCH v10 10/11] drm/bridge: analogix_dp: Add support for RK3576 Damon Ding
2026-06-04  4:37   ` Claude review: " Claude Code Review Bot
2026-06-01  6:51 ` [PATCH v10 11/11] drm/rockchip: " Damon Ding
2026-06-04  4:37   ` Claude Code Review Bot [this message]
2026-06-02 20:05 ` (subset) [PATCH v10 00/11] Add eDP " Heiko Stuebner
2026-06-02 20:41 ` Heiko Stuebner
2026-06-04  4:37 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-27  2:43 [PATCH v9 00/10] " Damon Ding
2026-05-27  2:43 ` [PATCH v9 10/10] drm/rockchip: analogix_dp: Add " Damon Ding
2026-05-27  3:55   ` Claude review: " Claude Code Review Bot
2026-05-25 12:53 [PATCH v8 00/10] Add eDP " Damon Ding
2026-05-25 12:53 ` [PATCH v8 10/10] drm/rockchip: analogix_dp: Add " Damon Ding
2026-05-25 21:12   ` Claude review: " Claude Code Review Bot
2026-05-25  8:20 [PATCH v7 00/10] Add eDP " Damon Ding
2026-05-25  8:20 ` [PATCH v7 10/10] drm/rockchip: analogix_dp: Add " Damon Ding
2026-05-25 21:34   ` Claude review: " Claude Code Review Bot
2026-05-21  8:08 [PATCH v6 00/10] Add eDP " Damon Ding
2026-05-21  8:08 ` [PATCH v6 10/10] drm/rockchip: analogix_dp: Add " Damon Ding
2026-05-25 10:40   ` Claude review: " Claude Code Review Bot
2026-05-13  7:44 [PATCH v5 00/10] Add eDP " Damon Ding
2026-05-13  7:44 ` [PATCH v5 10/10] drm/rockchip: analogix_dp: Add " Damon Ding
2026-05-16  2:26   ` Claude review: " Claude Code Review Bot
2026-03-19 10:40 [PATCH v2 0/9] Add eDP " Damon Ding
2026-03-20  0:45 ` [PATCH v2 9/9] drm/rockchip: analogix_dp: Add " Damon Ding
2026-03-21 18:26   ` Claude review: " Claude Code Review Bot
2026-03-10 10:53 [PATCH v1 0/4] Add eDP " Damon Ding
2026-03-10 10:53 ` [PATCH v1 4/4] drm/rockchip: analogix_dp: Add " Damon Ding
2026-03-11  3:27   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch11-20260601065100.1103873-12-damon.ding@rock-chips.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox