public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: video: leds: backlight: lm3533: Support getting LED sources from DT
Date: Thu, 04 Jun 2026 13:59:56 +1000	[thread overview]
Message-ID: <review-patch11-20260601151831.76350-12-clamor95@gmail.com> (raw)
In-Reply-To: <20260601151831.76350-12-clamor95@gmail.com>

Patch Review

**Bug: Wide mask clobbers other banks' LED source configurations.**

In `lm3533_bl_setup`:
```c
	ret = regmap_update_bits(bl->lm3533->regmap, LM3533_REG_OUTPUT_CONF1,
				 OUTPUT_CONF1_MASK, output_cfg_val);
```

`OUTPUT_CONF1_MASK = GENMASK(1, 0) = 0x03` covers BOTH HVLED1 and HVLED2 fields. If backlight bank B only configures HVLED1 (led-sources = <0>), the mask still writes bit 1 as 0, resetting HVLED2's assignment to bank A — even if bank A had previously configured HVLED2 differently. The same issue exists on the LED side:

```c
	ret = regmap_update_bits(led->lm3533->regmap, LM3533_REG_OUTPUT_CONF1,
				 OUTPUT_CONF1_MASK,
				 output_cfg_val << OUTPUT_CONF1_SHIFT);
```

`OUTPUT_CONF1_MASK = GENMASK(7, 2)` covers all three LVLED1/2/3 fields. Configuring one LVLED clobbers the other two. The original `lm3533_set_hvled_config` and `lm3533_set_lvled_config` correctly computed per-LED masks to avoid this. The fix is to build the mask dynamically alongside the value:

```c
	for (i = 0; i < bl->num_leds; i++) {
		if (bl->led_strings[i] >= LM3533_HVCTRLBANK_COUNT)
			continue;
		output_cfg_mask |= LM3533_BL_ID_MASK << bl->led_strings[i];
		output_cfg_val |= id << bl->led_strings[i];
	}
	ret = regmap_update_bits(..., output_cfg_mask, output_cfg_val);
```

**Possible undefined symbol:** `LM3533_LVCTRLBANK_MAX` is used in `leds-lm3533.c` for the `leds[]` array size and bounds check, but I don't see its definition in any patch diff. Verify this compiles — it may need to be added to the header or as a local define.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  3:59 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 15:18 [PATCH v3 00/11] mfd: lm3533: convert to OF bindings, improve support Svyatoslav Ryhel
2026-06-01 15:18 ` [PATCH v3 01/11] dt-bindings: leds: Document TI LM3533 LED controller Svyatoslav Ryhel
2026-06-02 13:49   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 02/11] mfd: lm3533: Remove driver specific regmap wrappers Svyatoslav Ryhel
2026-06-02  8:05   ` Andy Shevchenko
2026-06-02 10:18     ` Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 03/11] iio: light: lm3533-als: Remove redundant pdata helpers Svyatoslav Ryhel
2026-06-02  8:07   ` Andy Shevchenko
2026-06-02 13:42   ` Jonathan Cameron
2026-06-02 13:45     ` Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 04/11] mfd: lm3533-core: " Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 05/11] mfd: lm3533: Convert to use OF bindings Svyatoslav Ryhel
2026-06-02  8:23   ` Andy Shevchenko
2026-06-02 10:31     ` Svyatoslav Ryhel
2026-06-02 11:05       ` Andy Shevchenko
2026-06-02 12:00         ` Svyatoslav Ryhel
2026-06-02 13:46   ` Jonathan Cameron
2026-06-02 13:50     ` Svyatoslav Ryhel
2026-06-02 14:20       ` Jonathan Cameron
2026-06-02 14:28         ` Svyatoslav Ryhel
2026-06-02 13:49   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 06/11] mfd: lm3533: Add support for VIN power supply Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 07/11] mfd: lm3533: Set DMA mask Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 08/11] video: backlight: lm3533_bl: Improve linear sysfs logic Svyatoslav Ryhel
2026-06-02  8:09   ` Andy Shevchenko
2026-06-02 10:19     ` Svyatoslav Ryhel
2026-06-02 11:07       ` Andy Shevchenko
2026-06-02 11:59         ` Svyatoslav Ryhel
2026-06-02 13:55   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 09/11] video: backlight: lm3533_bl: Set initial mapping mode from DT Svyatoslav Ryhel
2026-06-02 14:05   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 10/11] video: backlight: lm3533_bl: Implement backlight_scale property Svyatoslav Ryhel
2026-06-02 14:06   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 11/11] video: leds: backlight: lm3533: Support getting LED sources from DT Svyatoslav Ryhel
2026-06-04  3:59   ` Claude Code Review Bot [this message]
2026-06-04  3:59 ` Claude review: mfd: lm3533: convert to OF bindings, improve support Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-17  7:43 [PATCH v1 0/6] " Svyatoslav Ryhel
2026-05-17  7:43 ` [PATCH v1 6/6] video: leds: backlight: lm3533: Support getting LED sources from DT Svyatoslav Ryhel
2026-05-18  6:19   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch11-20260601151831.76350-12-clamor95@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox