public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: mfd: lm3533: Remove driver specific regmap wrappers
Date: Thu, 04 Jun 2026 13:59:53 +1000	[thread overview]
Message-ID: <review-patch2-20260601151831.76350-3-clamor95@gmail.com> (raw)
In-Reply-To: <20260601151831.76350-3-clamor95@gmail.com>

Patch Review

**Bug: Swapped mask/val in lm3533_als_set_int_mode.**

The old `lm3533_update(lm3533, reg, val, mask)` wrapper internally calls `regmap_update_bits(regmap, reg, mask, val)` — the wrapper takes `(val, mask)` while regmap takes `(mask, val)`. Most call sites are converted correctly, but one is not:

```c
-	ret = lm3533_update(als->lm3533, LM3533_REG_ALS_ZONE_INFO, val, mask);
+	ret = regmap_update_bits(als->lm3533->regmap, LM3533_REG_ALS_ZONE_INFO,
+				 val, mask);
```

This should be `mask, val` (not `val, mask`). When `enable=false`, `val=0` and `mask=LM3533_ALS_INT_ENABLE_MASK`. The direct call becomes `regmap_update_bits(regmap, reg, 0, mask)` — a mask of 0 means no bits are touched, so disabling ALS interrupts becomes a no-op. The correct conversion is:

```c
	ret = regmap_update_bits(als->lm3533->regmap, LM3533_REG_ALS_ZONE_INFO,
				 mask, val);
```

All other `lm3533_update` → `regmap_update_bits` conversions in this patch are correct.

The `u8` → `u32` type changes for regmap_read output pointers are correct and necessary since `regmap_read` requires `unsigned int *`.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  3:59 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 15:18 [PATCH v3 00/11] mfd: lm3533: convert to OF bindings, improve support Svyatoslav Ryhel
2026-06-01 15:18 ` [PATCH v3 01/11] dt-bindings: leds: Document TI LM3533 LED controller Svyatoslav Ryhel
2026-06-02 13:49   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 02/11] mfd: lm3533: Remove driver specific regmap wrappers Svyatoslav Ryhel
2026-06-02  8:05   ` Andy Shevchenko
2026-06-02 10:18     ` Svyatoslav Ryhel
2026-06-04  3:59   ` Claude Code Review Bot [this message]
2026-06-01 15:18 ` [PATCH v3 03/11] iio: light: lm3533-als: Remove redundant pdata helpers Svyatoslav Ryhel
2026-06-02  8:07   ` Andy Shevchenko
2026-06-02 13:42   ` Jonathan Cameron
2026-06-02 13:45     ` Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 04/11] mfd: lm3533-core: " Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 05/11] mfd: lm3533: Convert to use OF bindings Svyatoslav Ryhel
2026-06-02  8:23   ` Andy Shevchenko
2026-06-02 10:31     ` Svyatoslav Ryhel
2026-06-02 11:05       ` Andy Shevchenko
2026-06-02 12:00         ` Svyatoslav Ryhel
2026-06-02 13:46   ` Jonathan Cameron
2026-06-02 13:50     ` Svyatoslav Ryhel
2026-06-02 14:20       ` Jonathan Cameron
2026-06-02 14:28         ` Svyatoslav Ryhel
2026-06-02 13:49   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 06/11] mfd: lm3533: Add support for VIN power supply Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 07/11] mfd: lm3533: Set DMA mask Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 08/11] video: backlight: lm3533_bl: Improve linear sysfs logic Svyatoslav Ryhel
2026-06-02  8:09   ` Andy Shevchenko
2026-06-02 10:19     ` Svyatoslav Ryhel
2026-06-02 11:07       ` Andy Shevchenko
2026-06-02 11:59         ` Svyatoslav Ryhel
2026-06-02 13:55   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 09/11] video: backlight: lm3533_bl: Set initial mapping mode from DT Svyatoslav Ryhel
2026-06-02 14:05   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 10/11] video: backlight: lm3533_bl: Implement backlight_scale property Svyatoslav Ryhel
2026-06-02 14:06   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 11/11] video: leds: backlight: lm3533: Support getting LED sources from DT Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-04  3:59 ` Claude review: mfd: lm3533: convert to OF bindings, improve support Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260601151831.76350-3-clamor95@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox