public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: mfd: lm3533: Convert to use OF bindings
Date: Thu, 04 Jun 2026 13:59:54 +1000	[thread overview]
Message-ID: <review-patch5-20260601151831.76350-6-clamor95@gmail.com> (raw)
In-Reply-To: <20260601151831.76350-6-clamor95@gmail.com>

Patch Review

This is the largest patch. The overall conversion from pdata to DT is well done — dynamic `mfd_cell` allocation from child nodes, parsing DT properties, removing all pdata structs.

**Bug: DT property name mismatch for ALS resistor.**

The binding schema (patch 1) defines the property as `ti,resistor-ohms`, but the driver reads:

```c
		ret = device_property_read_u32(dev, "ti,resistor-value-ohms",
					       &als->r_select);
```

This should be `"ti,resistor-ohms"` to match the binding.

**Typo in error message:**

```c
		return dev_err_probe(dev, ret,
				     "failed to ger resistor value\n");
```

"ger" should be "get".

**Minor observations:**

- The resistor ohms-to-register conversion `DIV_ROUND_UP(2 * MICRO, 10 * als->r_select)` is correct: for 1575 ohms → register 127, for 200000 ohms → register 1.

- `led->cdev.default_trigger = "none"` is unconventional; the standard approach is to leave it NULL when no trigger is specified. The subsequent `device_property_read_string` will overwrite it only if the DT property exists.

- Moving `LM3533_MAX_CURRENT_*` defines from `lm3533-ctrlbank.c` to the shared header is necessary since both LED and backlight drivers now clamp current values before calling `lm3533_ctrlbank_set_max_current`.

- The `boost_ovp` and `boost_freq` values are not initialized before the `clamp()` call. If the DT property is missing, `device_property_read_u32` leaves the variable uninitialized. Since `boost_ovp` and `boost_freq` are struct members (zero-initialized via devm_kzalloc), the default value 0 will be clamped to the minimum. This works but could be more explicit.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  3:59 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 15:18 [PATCH v3 00/11] mfd: lm3533: convert to OF bindings, improve support Svyatoslav Ryhel
2026-06-01 15:18 ` [PATCH v3 01/11] dt-bindings: leds: Document TI LM3533 LED controller Svyatoslav Ryhel
2026-06-02 13:49   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 02/11] mfd: lm3533: Remove driver specific regmap wrappers Svyatoslav Ryhel
2026-06-02  8:05   ` Andy Shevchenko
2026-06-02 10:18     ` Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 03/11] iio: light: lm3533-als: Remove redundant pdata helpers Svyatoslav Ryhel
2026-06-02  8:07   ` Andy Shevchenko
2026-06-02 13:42   ` Jonathan Cameron
2026-06-02 13:45     ` Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 04/11] mfd: lm3533-core: " Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 05/11] mfd: lm3533: Convert to use OF bindings Svyatoslav Ryhel
2026-06-02  8:23   ` Andy Shevchenko
2026-06-02 10:31     ` Svyatoslav Ryhel
2026-06-02 11:05       ` Andy Shevchenko
2026-06-02 12:00         ` Svyatoslav Ryhel
2026-06-02 13:46   ` Jonathan Cameron
2026-06-02 13:50     ` Svyatoslav Ryhel
2026-06-02 14:20       ` Jonathan Cameron
2026-06-02 14:28         ` Svyatoslav Ryhel
2026-06-02 13:49   ` Daniel Thompson
2026-06-04  3:59   ` Claude Code Review Bot [this message]
2026-06-01 15:18 ` [PATCH v3 06/11] mfd: lm3533: Add support for VIN power supply Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 07/11] mfd: lm3533: Set DMA mask Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 08/11] video: backlight: lm3533_bl: Improve linear sysfs logic Svyatoslav Ryhel
2026-06-02  8:09   ` Andy Shevchenko
2026-06-02 10:19     ` Svyatoslav Ryhel
2026-06-02 11:07       ` Andy Shevchenko
2026-06-02 11:59         ` Svyatoslav Ryhel
2026-06-02 13:55   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 09/11] video: backlight: lm3533_bl: Set initial mapping mode from DT Svyatoslav Ryhel
2026-06-02 14:05   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 10/11] video: backlight: lm3533_bl: Implement backlight_scale property Svyatoslav Ryhel
2026-06-02 14:06   ` Daniel Thompson
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-01 15:18 ` [PATCH v3 11/11] video: leds: backlight: lm3533: Support getting LED sources from DT Svyatoslav Ryhel
2026-06-04  3:59   ` Claude review: " Claude Code Review Bot
2026-06-04  3:59 ` Claude review: mfd: lm3533: convert to OF bindings, improve support Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-17  7:43 [PATCH v1 0/6] " Svyatoslav Ryhel
2026-05-17  7:43 ` [PATCH v1 2/6] mfd: lm3533: Convert to use OF bindings Svyatoslav Ryhel
2026-05-18  6:19   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260601151831.76350-6-clamor95@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox