public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: ti: beagley-ai: Enable HDMI display and audio
Date: Thu, 04 Jun 2026 16:54:13 +1000	[thread overview]
Message-ID: <review-patch15-20260529-beagley-ai-display-v3-15-7fefdc5d1adf@ideasonboard.com> (raw)
In-Reply-To: <20260529-beagley-ai-display-v3-15-7fefdc5d1adf@ideasonboard.com>

Patch Review

Enables HDMI via the IT66122 bridge chip on I2C1, with DSS1 VP0 driving 24-bit parallel video to the bridge. Also sets up MCASP1 for HDMI audio via simple-audio-card.

**Observations:**

- The DT uses DSS1 VP0 for HDMI with a comment noting VP choice. Good documentation.
- The `bootph-all` on `main_i2c1_pins_default` seems unnecessary for a display path that shouldn't be needed in early boot, but it's harmless.
- The `auxclk-fs-ratio = <2177>` for MCASP is an unusual value. The cover letter mentions "Sample-rate is off by 400 PPM" which suggests this ratio doesn't perfectly divide the master clock for standard audio sample rates, but 400 PPM is within typical acceptable limits.
- The pin mux for MCASP1_AXR0 is set as `PIN_OUTPUT` which is correct for TX.

No blocking issues.

**Summary:** The series is well-prepared for v3 with proper error handling improvements from v2. The main area I'd suggest looking at is the unconditional `clk_put(oldi->serial)` in the OLDI aux driver remove/error paths (patch 12) — while it's likely safe due to zeroed allocation, it would be cleaner to guard with a NULL check or mirror the conditional from probe. The rest looks solid and ready for merging.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  6:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29  8:45 [PATCH v3 00/15] drm/tidss: Add BeagleY-AI display support (and some more) Tomi Valkeinen
2026-05-29  8:45 ` [PATCH v3 01/15] dt-bindings: display: ti: Move ti,am62l-dss binding to a new binding file Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 02/15] dt-bindings: display: ti,am65x-dss: Simplify binding Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 03/15] dt-bindings: display: ti,am625-oldi: Add optional power-domain for OLDI Tomi Valkeinen
2026-05-30  8:55   ` Krzysztof Kozlowski
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 04/15] dt-bindings: display: ti,am65x-dss: Add ti,dpi-io-ctrl Tomi Valkeinen
2026-05-30  8:58   ` Krzysztof Kozlowski
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 05/15] dt-bindings: display: ti,am65x-dss: Add AM62P DSS Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 06/15] drm/tidss: Remove extra pm_runtime_mark_last_busy Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 07/15] drm/tidss: oldi: Remove define for unused register OLDI_LB_CTRL Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 08/15] drm/tidss: Add mechanism to detect DPI output Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 09/15] drm/tidss: Add external data and sync signal edge configuration Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 10/15] drm/tidss: Add support for DPIENABLE bit Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 11/15] drm/tidss: oldi: Fix OLDI signal polarities Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 12/15] drm/tidss: oldi: Convert OLDI to an aux driver Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 13/15] drm/tidss: Add support for AM62P display subsystem Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 14/15] arm64: dts: ti: k3-am62p-j722s-common-main: Add support for DSS Tomi Valkeinen
2026-06-04  6:54   ` Claude review: " Claude Code Review Bot
2026-05-29  8:45 ` [PATCH v3 15/15] arm64: dts: ti: beagley-ai: Enable HDMI display and audio Tomi Valkeinen
2026-06-04  6:54   ` Claude Code Review Bot [this message]
2026-06-04  6:54 ` Claude review: drm/tidss: Add BeagleY-AI display support (and some more) Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-13 13:17 [PATCH v2 00/16] " Tomi Valkeinen
2026-05-13 13:17 ` [PATCH v2 16/16] arm64: dts: ti: beagley-ai: Enable HDMI display and audio Tomi Valkeinen
2026-05-16  2:00   ` Claude review: " Claude Code Review Bot
2026-04-20 12:54 [PATCH 00/15] drm/tidss: Add BeagleY-AI display support (and some more) Tomi Valkeinen
2026-04-20 12:54 ` [PATCH 15/15] arm64: dts: ti: beagley-ai: Enable HDMI display and audio Tomi Valkeinen
2026-04-22 23:46   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch15-20260529-beagley-ai-display-v3-15-7fefdc5d1adf@ideasonboard.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox