From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/mdss: use new helper to set amsbc
Date: Mon, 25 May 2026 21:42:00 +1000 [thread overview]
Message-ID: <review-patch19-20260520-ubwc-rework-v5-19-72f2749bc807@oss.qualcomm.com> (raw)
In-Reply-To: <20260520-ubwc-rework-v5-19-72f2749bc807@oss.qualcomm.com>
Patch Review
```c
- if (data->ubwc_enc_version == UBWC_3_0)
+ if (qcom_ubwc_enable_amsbc(data))
value |= MDSS_UBWC_STATIC_UBWC_AMSBC;
```
**Note:** This changes behavior -- the old code only set AMSBC for exactly UBWC_3_0 in the MDSS `5x_setup_ubwc` path. The helper returns `>= UBWC_3_0`, which would include UBWC_4_0+ if such SoCs ever used the 5x setup path. This is correct because the 5x setup path is only used by older SoCs, and the change aligns it with how GPU drivers already treat amsbc.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 11:42 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 14:51 [PATCH v5 00/28] soc/qcom/ubwc: rework UBWC configuration database Dmitry Baryshkov
2026-05-20 14:51 ` [PATCH v5 01/28] soc: qcom: ubwc: define UBWC 3.1 Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 02/28] soc: qcom: ubwc: define helper for MDSS and Adreno drivers Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 03/28] soc: qcom: ubwc: add helper controlling AMSBC enablement Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 04/28] drm/msm/adreno: Trust the SSoT UBWC config Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 05/28] drm/msm/adreno: use qcom_ubwc_version_tag() helper Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 06/28] drm/msm/mdss: " Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 07/28] drm/msm/adreno: use new helper to set min_acc length Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 08/28] drm/msm/mdss: " Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 09/28] drm/msm/adreno: use new helper to set macrotile_mode Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 10/28] drm/msm/mdss: " Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 11/28] drm/msm/mdss: use new helper to set UBWC bank spreading Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 12/28] drm/msm/adreno: use new helper to set ubwc_swizzle Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 13/28] drm/msm/dpu: " Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 14/28] drm/msm/mdss: " Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 15/28] drm/msm/adreno: write reserved UBWC-related bits Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 16/28] drm/msm/adreno: set fp16compoptdis for UBWC 3.0 formats Dmitry Baryshkov
2026-05-25 11:41 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 17/28] drm/msm/adreno: use new helper to set amsbc Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 18/28] drm/msm/adreno: use version ranges in A8xx UBWC code Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 19/28] drm/msm/mdss: use new helper to set amsbc Dmitry Baryshkov
2026-05-25 11:42 ` Claude Code Review Bot [this message]
2026-05-20 14:51 ` [PATCH v5 20/28] drm/msm/dpu: drop ubwc_dec_version Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 21/28] drm/msm/dpu: invert the order of UBWC checks Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 22/28] soc: qcom: ubwc: set min_acc length to 64 for all UBWC 1.0 targets Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 23/28] soc: qcom: ubwc: drop ubwc_dec_version Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 24/28] soc: qcom: ubwc: drop ubwc_bank_spread Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 25/28] soc: qcom: ubwc: drop macrotile_mode from the database Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 26/28] soc: qcom: ubwc: use fixed values for UBWC swizzle for UBWC < 4.0 Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 27/28] soc: qcom: ubwc: sort out the rest of the UBWC swizzle settings Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-20 14:51 ` [PATCH v5 28/28] soc: qcom: ubwc: deduplicate UBWC configuration data Dmitry Baryshkov
2026-05-25 11:42 ` Claude review: " Claude Code Review Bot
2026-05-25 11:41 ` Claude review: soc/qcom/ubwc: rework UBWC configuration database Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-12 13:29 [PATCH v3 00/27] " Dmitry Baryshkov
2026-03-12 13:29 ` [PATCH v3 17/27] drm/msm/mdss: use new helper to set amsbc Dmitry Baryshkov
2026-03-13 4:12 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch19-20260520-ubwc-rework-v5-19-72f2749bc807@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox