From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: i810: Use safer strscpy() instead of strcpy()
Date: Tue, 28 Apr 2026 15:38:39 +1000 [thread overview]
Message-ID: <review-patch2-20260425065926.1091168-3-aichao@kylinos.cn> (raw)
In-Reply-To: <20260425065926.1091168-3-aichao@kylinos.cn>
Patch Review
**Files:** `i810-i2c.c`, `i810_main.c` — 2 replacements
The string conversions themselves are fine:
- `name` → `chan->adapter.name` (`char[48]`)
- `"I810"` (5 bytes) → `fix->id` (`char[16]`)
**Issue: undeclared whitespace change.** Both hunks silently convert leading spaces to tabs:
```c
- strcpy(chan->adapter.name, name);
+ strscpy(chan->adapter.name, name);
```
```c
- strcpy(fix->id, "I810");
+ strscpy(fix->id, "I810");
```
The commit message says "Only idiomatic code replacement, and no functional changes" but the indentation change is a separate style fix that should either be split out or mentioned. Mixing whitespace changes with functional changes makes `git blame` noisier.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 5:38 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 6:58 [PATCH 00/35] Use safer strscpy() instead of strcpy() Ai Chao
2026-04-25 6:58 ` [PATCH 01/35] fbdev: matroxfb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:58 ` [PATCH 02/35] fbdev: i810: " Ai Chao
2026-04-28 5:38 ` Claude Code Review Bot [this message]
2026-04-25 6:58 ` [PATCH 03/35] fbdev: sisfb: " Ai Chao
2026-04-25 8:08 ` Helge Deller
2026-04-25 11:02 ` David Laight
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:58 ` [PATCH 04/35] fbdev: geode: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:58 ` [PATCH 05/35] fbdev: atafb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:58 ` [PATCH 06/35] fbdev: tdfxfb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:58 ` [PATCH 07/35] fbdev: pm2fb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:58 ` [PATCH 08/35] fbdev: xen-fbfront: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 09/35] fbdev: controlfb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 10/35] fbdev: stifb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 11/35] fbdev: fm2fb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 12/35] fbdev: arkfb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 13/35] fbdev: vt8500lcdfb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 14/35] fbdev: vt8623fb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 15/35] fbdev: gbefb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 16/35] fbdev: wm8505fb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 17/35] fbdev: rivafb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 18/35] fbdev: sh7760fb: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-25 6:59 ` [PATCH 19/35] fbdev: savage: " Ai Chao
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
2026-04-28 5:38 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260425065926.1091168-3-aichao@kylinos.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox