Claude review: Re: [PATCH 03/35] fbdev: sisfb: Use safer strscpy() instead of strcpy()

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Files:** `sis/sis_main.c` — 8 replacements

The 7 `ivideo->myid` replacements (e.g., `"SiS 730"` → `char myid[40]`) are trivially safe.

**Worth noting:** The `strbuf1` case is qualitatively different from the rest of the series:

```c
if(strlen(name) <= 19) {
    strscpy(strbuf1, name);
```

Here `strbuf1` is `char[20]` and the source is a runtime variable `name`, not a compile-time literal. The `strlen(name) <= 19` guard means the original `strcpy()` was already safe, but `strscpy()` adds defense-in-depth. This is genuinely a different pattern from copying a known-short literal into a known-large buffer — the commit message should acknowledge this rather than claiming all changes are identical.

**Reviewed-by: acceptable with nit**

---

---
Generated by Claude Code Patch Reviewer