public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: dmub_cmd.h: add missing kernel-doc for enums
Date: Tue, 28 Apr 2026 13:53:32 +1000	[thread overview]
Message-ID: <review-patch2-20260427214122.784024-3-rdunlap@infradead.org> (raw)
In-Reply-To: <20260427214122.784024-3-rdunlap@infradead.org>

Patch Review

**Status: Good to merge.**

This patch fixes 12 kernel-doc warnings where the comment prototype name didn't match the actual type name. Each fix is a one-line change to the `/** ... */` comment header. All corrections align the documented name with the actual declaration immediately following:

- `dmub_trace_code_t` → `typedef dmub_trace_code_t` (typedef needs the keyword)
- `struct dmub_shared_state_ips_fw` → `struct dmub_shared_state_ips_fw_signals`
- `struct dmub_shared_state_ips_signals` → `struct dmub_shared_state_ips_driver_signals`
- `struct dmub_shared_state_cursor_offload_v1` → `struct dmub_shared_state_cursor_offload_stream_v1`
- `enum dmub_shared_state_feature_common` → `struct dmub_shared_state_feature_common`
- `enum dmub_shared_state_feature_header` → `struct dmub_shared_state_feature_header`
- `struct dmub_cmd_read_modify_write_sequence` → `struct dmub_rb_cmd_read_modify_write`
- `struct dmub_rb_cmd_cab` → `struct dmub_rb_cmd_cab_for_ss`
- `struct dmub_cmd_set_pixel_clock_data` → `struct dmub_rb_cmd_set_pixel_clock`
- `union dpia_notify_data_type` → `union dpia_notification_data`
- `struct dmub_rb_cmd_hpd_sense_notify` → `struct dmub_rb_cmd_hpd_sense_notify_data`
- `struct dmub_cmd_cable_id_input` → `struct dmub_cmd_cable_id_output`

Each one is verified by checking that the corrected name matches the actual declaration that follows the comment block. No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-28  3:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 21:41 [PATCH 1/3 v2] drm/amd/display: dmub_cmd.h: correct typos and spellos Randy Dunlap
2026-04-27 21:41 ` [PATCH 2/3 v2] drm/amd/display: dmub_cmd.h: correct all kernel-doc prototype warnings Randy Dunlap
2026-04-28  3:53   ` Claude review: " Claude Code Review Bot
2026-04-27 21:41 ` [PATCH 3/3 v2] drm/amd/display: dmub_cmd.h: add missing kernel-doc for enums Randy Dunlap
2026-04-28  3:53   ` Claude Code Review Bot [this message]
2026-04-28  3:53 ` Claude review: drm/amd/display: dmub_cmd.h: correct typos and spellos Claude Code Review Bot
2026-04-28  3:53 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260427214122.784024-3-rdunlap@infradead.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox