From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: dmub_cmd.h: correct all kernel-doc prototype warnings
Date: Tue, 28 Apr 2026 13:53:32 +1000 [thread overview]
Message-ID: <review-patch3-20260427214122.784024-2-rdunlap@infradead.org> (raw)
In-Reply-To: <20260427214122.784024-2-rdunlap@infradead.org>
Patch Review
**Status: Good to merge.**
This patch adds proper `@ENUM_VALUE:` kernel-doc annotations to enum values that were missing them, and converts a few `/**` comment blocks to plain `/*` where no kernel-doc content was present.
The changes fall into three categories:
1. **Adding `@VALUE_NAME:` tags** to existing `/**` doc comments — e.g.:
```c
/** @DMUB_CMD__MALL_ACTION_ALLOW: Allows display refresh from MALL. */
```
This follows the standard kernel-doc format for enum values.
2. **Converting `/**` to `/*`** for enums without real documentation content (e.g., `dmub_shared_state_feature_id`, `mclk_switch_mode`, `dmub_idle_opt_dc_power_state`, `dmub_phy_fsm_state`). This is the correct approach — `/**` signals kernel-doc, and if there's no actual kernel-doc content, it generates warnings.
3. **Reformatting inline `/**< ... */` comments** into multi-line `/** @NAME: description */` blocks for `dmub_fw_boot_status_bit`. The content is preserved; only the format changes.
Minor nit: in `DMUB_FW_BOOT_STATUS_BIT_ONO_REGIONS_ENABLED`, the original comment said "1 if ONO regions are enabled" but the updated version drops the "1":
```c
/** @DMUB_FW_BOOT_STATUS_BIT_ONO_REGIONS_ENABLED: if ONO regions are enabled */
```
All the other entries in this enum say "1 if ...". This is trivial but inconsistent.
Overall, all three patches are clean, correct, and ready to merge.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-28 3:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 21:41 [PATCH 1/3 v2] drm/amd/display: dmub_cmd.h: correct typos and spellos Randy Dunlap
2026-04-27 21:41 ` [PATCH 2/3 v2] drm/amd/display: dmub_cmd.h: correct all kernel-doc prototype warnings Randy Dunlap
2026-04-28 3:53 ` Claude Code Review Bot [this message]
2026-04-27 21:41 ` [PATCH 3/3 v2] drm/amd/display: dmub_cmd.h: add missing kernel-doc for enums Randy Dunlap
2026-04-28 3:53 ` Claude review: " Claude Code Review Bot
2026-04-28 3:53 ` Claude review: drm/amd/display: dmub_cmd.h: correct typos and spellos Claude Code Review Bot
2026-04-28 3:53 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260427214122.784024-2-rdunlap@infradead.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox