public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: dmub_cmd.h: correct typos and spellos
Date: Tue, 28 Apr 2026 13:53:32 +1000	[thread overview]
Message-ID: <review-patch1-20260427214122.784024-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260427214122.784024-1-rdunlap@infradead.org>

Patch Review

**Status: Good to merge.**

This patch fixes 20+ spelling errors identified by codespell and a handful found manually. All corrections are straightforward and obviously correct:

- `alighment` → `alignment` (1x)
- `sequeunce` → `sequence` (1x)
- `optimzations` → `optimizations` (3x)
- `isntance` → `instance` (16x)
- `re-use` → `reuse` (1x)
- `dicated` → `dictated` (7x)
- `afftet` → `after` (1x)

The `afftet` → `after` fix deserves a note. The resulting comment reads:
```c
/*
 * Use FSFT after pixel clk
 */
uint32_t pix_clk_100hz;
```
This is grammatically terse but plausible in context — the adjacent field `sink_pix_clk_100hz` has the comment "Use Original pixel clock", so "after" likely means "after FSFT adjustment". The original `afftet` was clearly garbled, and `after` is the best reasonable interpretation.

Randy's open questions about pre-existing comment/field mismatches are well-spotted:
- **(a)** `dark_pos_gain` with comment "Dark negative gain" — "pos" and "negative" contradict each other.
- **(b)/(c)** `min_frame_rate` has comment "Maximum frame rate" and `max_frame_rate` has "Minimum frame rate" — the comments are clearly swapped.

These are real bugs in the existing documentation but are correctly left out of this patch, as they require AMD domain knowledge to resolve which name (field vs comment) is correct. A follow-up fix from the AMD display team would be appropriate.

One very minor nit: the double period at the end of this comment was not fixed:
```c
 * 16-bit value dictated by driver that indicates the vtotal in PSR active requirement when screen idle..
```
The trailing `..` should probably be a single `.`, but that's pre-existing and doesn't affect the correctness of this patch.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-28  3:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27 21:41 [PATCH 1/3 v2] drm/amd/display: dmub_cmd.h: correct typos and spellos Randy Dunlap
2026-04-27 21:41 ` [PATCH 2/3 v2] drm/amd/display: dmub_cmd.h: correct all kernel-doc prototype warnings Randy Dunlap
2026-04-28  3:53   ` Claude review: " Claude Code Review Bot
2026-04-27 21:41 ` [PATCH 3/3 v2] drm/amd/display: dmub_cmd.h: add missing kernel-doc for enums Randy Dunlap
2026-04-28  3:53   ` Claude review: " Claude Code Review Bot
2026-04-28  3:53 ` Claude review: drm/amd/display: dmub_cmd.h: correct typos and spellos Claude Code Review Bot
2026-04-28  3:53 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260427214122.784024-1-rdunlap@infradead.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox