public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: add of_drm_get_bridge_by_endpoint()
Date: Sat, 16 May 2026 15:02:22 +1000	[thread overview]
Message-ID: <review-patch2-20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-2-f61c9e498b3f@bootlin.com> (raw)
In-Reply-To: <20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-2-f61c9e498b3f@bootlin.com>

Patch Review

The new function is a clean wrapper around `of_drm_find_and_get_bridge()` with OF graph resolution. Key details look correct:

```c
bridge = of_drm_find_and_get_bridge(remote);
if (!bridge)
    return ERR_PTR(-EPROBE_DEFER);
```

This correctly converts the NULL return from `of_drm_find_and_get_bridge()` (bridge registered but not yet available) into `-EPROBE_DEFER`, matching the semantics of the old `drm_of_find_panel_or_bridge()`.

The non-OF inline stub correctly returns `ERR_PTR(-ENODEV)` rather than NULL, consistent with the new API contract.

**Very minor nit:** The kdoc return description is missing a trailing period:
```
 * Returns a pointer to the connected drm_bridge, or a negative error on failure
```

Already has R-by from Dmitry and Laurent. No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  5:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 16:40 [PATCH v6 00/11] drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-11 16:40 ` [PATCH v6 01/11] drm/bridge: drm_bridge_put(): ignore ERR_PTR Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 02/11] drm/bridge: add of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-16  5:02   ` Claude Code Review Bot [this message]
2026-05-11 16:40 ` [PATCH v6 03/11] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-13 13:24   ` Dmitry Baryshkov
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 04/11] drm/hisilicon/kirin: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 05/11] drm/bridge: chrontel-ch7033: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 06/11] drm/bridge: lontium-lt9611uxc: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 07/11] drm/bridge: lt9611: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 08/11] drm/bridge: adv7511: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 09/11] drm/bridge: lt8713sx: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 10/11] drm: zynqmp_dp: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 11/11] drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-16  5:02 ` Claude review: drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-04 10:45 [PATCH v4 00/11] " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 02/11] drm/bridge: add of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-04 22:26   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-2-f61c9e498b3f@bootlin.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox