public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge()
Date: Sat, 16 May 2026 15:02:22 +1000	[thread overview]
Message-ID: <review-overall-20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-0-f61c9e498b3f@bootlin.com> (raw)
In-Reply-To: <20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-0-f61c9e498b3f@bootlin.com>

Overall Series Review

Subject: drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge()
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>
Patches: 13
Reviewed: 2026-05-16T15:02:22.126708

---

This is a well-structured, incremental series that continues Luca Ceresoli's long-running work to add proper refcounting to DRM bridges. The series introduces `of_drm_get_bridge_by_endpoint()` as a refcount-aware replacement for bridge-only calls to the deprecated `drm_of_find_panel_or_bridge()`, converts all bridge-only callers, and then forbids that usage pattern going forward.

The approach is sound: the new API is simpler (returns the bridge directly instead of via double-pointer), safer (refcounted), and each driver conversion correctly handles the lifecycle of the returned bridge — either via the auto-put `bridge.next_bridge` field, explicit `drm_bridge_put()`, or the `__free(drm_bridge_put)` cleanup annotation.

All patches are already reviewed/acked except patches 3 and 4. The series is at v6, with the main changes across versions being error handling improvements. The code quality is high and the pattern is consistent.

**No blocking issues found.** A couple of very minor nits below.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  5:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 16:40 [PATCH v6 00/11] drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-11 16:40 ` [PATCH v6 01/11] drm/bridge: drm_bridge_put(): ignore ERR_PTR Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 02/11] drm/bridge: add of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 03/11] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-13 13:24   ` Dmitry Baryshkov
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 04/11] drm/hisilicon/kirin: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 05/11] drm/bridge: chrontel-ch7033: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 06/11] drm/bridge: lontium-lt9611uxc: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 07/11] drm/bridge: lt9611: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 08/11] drm/bridge: adv7511: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 09/11] drm/bridge: lt8713sx: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 10/11] drm: zynqmp_dp: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 11/11] drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-16  5:02 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-04 10:45 [PATCH v4 00/11] drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-04 22:26 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-0-f61c9e498b3f@bootlin.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox