public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint()
Date: Sat, 16 May 2026 15:02:22 +1000	[thread overview]
Message-ID: <review-patch3-20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-3-f61c9e498b3f@bootlin.com> (raw)
In-Reply-To: <20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-3-f61c9e498b3f@bootlin.com>

Patch Review

This is the most involved conversion because the MSM HDMI driver's bridge is in a separate `hdmi_bridge` struct (allocated in `hdmi_bridge.c`), not embedded in the `hdmi` struct. So unlike later patches, this one can't use the auto-put `bridge.next_bridge` field and must manage the refcount explicitly.

The conversion correctly:
- Handles the `-ENODEV` case by setting `hdmi->next_bridge = NULL` (preserving old behavior)
- Changes all early-return paths after the bridge lookup to `goto err_put_bridge`
- Adds `drm_bridge_put(hdmi->next_bridge)` in both `err_put_bridge` and `msm_hdmi_dev_remove()`

The `drm_bridge_put()` in the remove function is safe even if `next_bridge` is NULL (patch 1 ensures this).

**Minor nit:** There's a double blank line introduced at the `devm_clk_bulk_get` error path:
```c
 	if (ret)
-		return ret;
+		goto err_put_bridge;
+
 
 	hdmi->extp_clk = devm_clk_get_optional(dev, "extp");
```

No functional issues. This patch needs review/ack from MSM maintainers.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  5:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 16:40 [PATCH v6 00/11] drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-11 16:40 ` [PATCH v6 01/11] drm/bridge: drm_bridge_put(): ignore ERR_PTR Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 02/11] drm/bridge: add of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 03/11] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-13 13:24   ` Dmitry Baryshkov
2026-05-16  5:02   ` Claude Code Review Bot [this message]
2026-05-11 16:40 ` [PATCH v6 04/11] drm/hisilicon/kirin: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 05/11] drm/bridge: chrontel-ch7033: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 06/11] drm/bridge: lontium-lt9611uxc: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 07/11] drm/bridge: lt9611: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 08/11] drm/bridge: adv7511: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 09/11] drm/bridge: lt8713sx: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 10/11] drm: zynqmp_dp: " Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-11 16:40 ` [PATCH v6 11/11] drm: of: forbid bridge-only calls to drm_of_find_panel_or_bridge() Luca Ceresoli
2026-05-16  5:02   ` Claude review: " Claude Code Review Bot
2026-05-16  5:02 ` Claude review: drm/bridge: handle refcounting for bridge-only callers of drm_of_find_panel_or_bridge() Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-04 10:45 [PATCH v4 00/11] " Luca Ceresoli
2026-05-04 10:45 ` [PATCH v4 03/11] drm/msm/hdmi: switch to of_drm_get_bridge_by_endpoint() Luca Ceresoli
2026-05-04 22:26   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260511-drm-bridge-alloc-getput-panel_or_bridge-v6-3-f61c9e498b3f@bootlin.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox