public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display/msm: gpu: Document Adreno 840
Date: Sat, 16 May 2026 14:35:13 +1000	[thread overview]
Message-ID: <review-patch2-20260512-kaana-gpu-dt-v1-2-13e1c07c2050@oss.qualcomm.com> (raw)
In-Reply-To: <20260512-kaana-gpu-dt-v1-2-13e1c07c2050@oss.qualcomm.com>

Patch Review

**Status: Looks good**

Two changes:

1. Converts the reg-layout conditional from `const` to `enum` to include both `qcom,adreno-44050a01` (Adreno 840) and `qcom,adreno-44070001`:

```diff
-            const: qcom,adreno-44070001
+            enum:
+              - qcom,adreno-44050a01
+              - qcom,adreno-44070001
```

2. Adds `qcom,adreno-44050a01` to the "clocks: false" enum list (since clocks are defined in the GMU node for A6xx+):

```diff
               - qcom,adreno-43051401
+              - qcom,adreno-44050a01
               - qcom,adreno-44070001
```

Both changes are correct. The new compatible string is placed in sorted order in both locations. The Adreno 840 shares the same reg layout as 44070001 and follows the same GMU-based clock pattern as other modern Adreno GPUs.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  4:35 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 22:23 [PATCH 0/8] arm64: dts: qcom: Devicetree support for Kaanapali GPU Akhil P Oommen
2026-05-11 22:23 ` [PATCH 1/8] dt-bindings: arm-smmu: Update the description for Kaanapali GPU SMMU Akhil P Oommen
2026-05-15  8:41   ` Krzysztof Kozlowski
2026-05-15 20:26     ` Akhil P Oommen
2026-05-16  4:35   ` Claude review: " Claude Code Review Bot
2026-05-11 22:23 ` [PATCH 2/8] dt-bindings: display/msm: gpu: Document Adreno 840 Akhil P Oommen
2026-05-16  4:35   ` Claude Code Review Bot [this message]
2026-05-11 22:23 ` [PATCH 3/8] arm64: dts: qcom: kaanapali: add the GPU SMMU node Akhil P Oommen
2026-05-13 16:51   ` Dmitry Baryshkov
2026-05-14 12:36   ` Konrad Dybcio
2026-05-16  4:35   ` Claude review: " Claude Code Review Bot
2026-05-11 22:23 ` [PATCH 4/8] arm64: dts: qcom: kaanapali: Add qfprom node Akhil P Oommen
2026-05-13 16:52   ` Dmitry Baryshkov
2026-05-14 12:44   ` Konrad Dybcio
2026-05-16  4:35   ` Claude review: " Claude Code Review Bot
2026-05-11 22:23 ` [PATCH 5/8] arm64: dts: qcom: Add GPU support for Kaanapali Akhil P Oommen
2026-05-13 16:53   ` Dmitry Baryshkov
2026-05-14 12:43   ` Konrad Dybcio
2026-05-15 22:08     ` Akhil P Oommen
2026-05-16  4:35   ` Claude review: " Claude Code Review Bot
2026-05-11 22:23 ` [PATCH 6/8] arm64: dts: qcom: kaanapali: Add GPU cooling Akhil P Oommen
2026-05-13 17:53   ` Dmitry Baryshkov
2026-05-14  6:47     ` Gaurav Kohli
2026-05-16  4:35   ` Claude review: " Claude Code Review Bot
2026-05-11 22:23 ` [PATCH 7/8] arm64: dts: qcom: kaanapali-mtp: Enable GPU Akhil P Oommen
2026-05-13 17:54   ` Dmitry Baryshkov
2026-05-14 12:36   ` Konrad Dybcio
2026-05-16  4:35   ` Claude review: " Claude Code Review Bot
2026-05-11 22:23 ` [PATCH 8/8] arm64: dts: qcom: kaanapali-qrd: " Akhil P Oommen
2026-05-13 17:54   ` Dmitry Baryshkov
2026-05-14 12:37   ` Konrad Dybcio
2026-05-16  4:35   ` Claude review: " Claude Code Review Bot
2026-05-16  4:35 ` Claude review: arm64: dts: qcom: Devicetree support for Kaanapali GPU Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260512-kaana-gpu-dt-v1-2-13e1c07c2050@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox