From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ras: Introduce get-error-threshold
Date: Sat, 16 May 2026 12:54:49 +1000 [thread overview]
Message-ID: <review-patch2-20260512191610.1817578-3-raag.jadav@intel.com> (raw)
In-Reply-To: <20260512191610.1817578-3-raag.jadav@intel.com>
Patch Review
Adds the `GET_ERROR_THRESHOLD` netlink command to drm_ras. The implementation follows the existing `GET_ERROR_COUNTER` pattern closely.
**Issue: `get-error-threshold` requires `admin-perm` for a read-only query.**
```yaml
flags: [admin-perm]
```
The existing `get-error-counter` is a dump operation without `admin-perm`. It's worth questioning whether a threshold query truly requires admin privileges. If the intent is to keep parity with `set-error-threshold` that's one thing, but for a read-only query it seems unnecessarily restrictive compared to the existing counter read path.
**Minor: No `dumpit` handler for thresholds.**
Unlike `get-error-counter` which has both `doit` and `dumpit`, `get-error-threshold` only has `doit`. If a user wants to query thresholds for all errors across all nodes, they need to iterate manually. This may be intentional but is worth noting for completeness.
The core implementation is solid — proper cleanup paths with `genlmsg_cancel`/`nlmsg_free` on errors, correct attribute checking, and the `EOPNOTSUPP` return when the callback is absent.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 2:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 19:16 [PATCH v2 0/9] Introduce error threshold to drm_ras Raag Jadav
2026-05-12 19:16 ` [PATCH v2 1/9] drm/ras: Update counter helpers with counter naming Raag Jadav
2026-05-12 20:49 ` Rodrigo Vivi
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 2/9] drm/ras: Introduce get-error-threshold Raag Jadav
2026-05-16 2:54 ` Claude Code Review Bot [this message]
2026-05-12 19:16 ` [PATCH v2 3/9] drm/ras: Introduce set-error-threshold Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 4/9] drm/xe/uapi: Add additional error components to xe drm_ras Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 5/9] drm/xe/ras: Get error threshold support Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 6/9] drm/xe/ras: Set " Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 7/9] drm/xe/drm_ras: Wire up error threshold callbacks Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 8/9] drm/xe/xe_ras: Move xe drm_ras registration Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 9/9] drm/xe/xe_ras: Control xe drm_ras registration with a flag Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-16 2:54 ` Claude review: Introduce error threshold to drm_ras Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260512191610.1817578-3-raag.jadav@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox