From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/xe_ras: Move xe drm_ras registration
Date: Sat, 16 May 2026 12:54:51 +1000 [thread overview]
Message-ID: <review-patch8-20260512191610.1817578-9-raag.jadav@intel.com> (raw)
In-Reply-To: <20260512191610.1817578-9-raag.jadav@intel.com>
Patch Review
Moves `xe_drm_ras_init()` call from `xe_hw_error_init()` into a new `xe_ras_init()` function, and reorders `xe_soc_remapper_init()` and `xe_sysctrl_init()` earlier in the probe sequence.
**Issue: Commit message has typos.**
```
gove xe drm_ras registration to RAS initialization flow and keep
gardware error initialization for processing errors reported
via irq.
```
"gove" should be "Move", "gardware" should be "hardware". These look like keyboard transposition errors and should be fixed before merge.
**Concern: Probe ordering change risk.** Moving `xe_soc_remapper_init()` and `xe_sysctrl_init()` earlier — before `xe_display_init_early()` — is a significant probe ordering change. The original code had them much later (after GT init, IRQ install, etc.). The commit message says this is because "ras init is dependent on both", which is true, but the move also changes when these subsystems initialize relative to display, IRQ, and GT init. If `xe_soc_remapper_init` or `xe_sysctrl_init` had any implicit dependencies on GT or IRQ being set up, this could break. The series should confirm that these subsystems have no such dependencies.
**Note: Error handling difference.** The old code used `drm_err` with `%pe` format specifier (ERR_PTR). The new code uses `%d`:
```c
// Old (removed from xe_hw_error.c):
drm_err(&xe->drm, "Failed to initialize XE DRM RAS (%pe)\n", ERR_PTR(ret));
// New (in xe_ras.c):
drm_err(&xe->drm, "Failed to initialize xe_drm_ras %d\n", ret);
```
Using `%pe` is the preferred kernel style for printing errno values as human-readable strings. The new code should use `%pe` for consistency.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 2:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 19:16 [PATCH v2 0/9] Introduce error threshold to drm_ras Raag Jadav
2026-05-12 19:16 ` [PATCH v2 1/9] drm/ras: Update counter helpers with counter naming Raag Jadav
2026-05-12 20:49 ` Rodrigo Vivi
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 2/9] drm/ras: Introduce get-error-threshold Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 3/9] drm/ras: Introduce set-error-threshold Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 4/9] drm/xe/uapi: Add additional error components to xe drm_ras Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 5/9] drm/xe/ras: Get error threshold support Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 6/9] drm/xe/ras: Set " Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 7/9] drm/xe/drm_ras: Wire up error threshold callbacks Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-12 19:16 ` [PATCH v2 8/9] drm/xe/xe_ras: Move xe drm_ras registration Raag Jadav
2026-05-16 2:54 ` Claude Code Review Bot [this message]
2026-05-12 19:16 ` [PATCH v2 9/9] drm/xe/xe_ras: Control xe drm_ras registration with a flag Raag Jadav
2026-05-16 2:54 ` Claude review: " Claude Code Review Bot
2026-05-16 2:54 ` Claude review: Introduce error threshold to drm_ras Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch8-20260512191610.1817578-9-raag.jadav@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox