From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: kunit: Add backtrace suppression self-tests
Date: Sat, 16 May 2026 10:56:13 +1000 [thread overview]
Message-ID: <review-patch2-20260514-kunit_add_support-v11-2-b36a530a6d8f@redhat.com> (raw)
In-Reply-To: <20260514-kunit_add_support-v11-2-b36a530a6d8f@redhat.com>
Patch Review
**Overall: Good test coverage.** Tests the scoped API, direct API, incremental counting, active state transitions, multi-scope with independent handles, and cross-kthread isolation.
**`backtrace_suppression_test_warn_on_direct` has an asymmetric skip condition:**
```c
+ if (!IS_ENABLED(CONFIG_DEBUG_BUGVERBOSE) && !IS_ENABLED(CONFIG_KALLSYMS))
+ kunit_skip(test, "requires CONFIG_DEBUG_BUGVERBOSE or CONFIG_KALLSYMS");
```
While `backtrace_suppression_test_warn_on_indirect` requires only:
```c
+ if (!IS_ENABLED(CONFIG_DEBUG_BUGVERBOSE))
+ kunit_skip(test, "requires CONFIG_DEBUG_BUGVERBOSE");
```
The difference is intentional: `WARN_ON()` inlined directly can use `KALLSYMS` to resolve the caller, while when called through `noinline` it cannot. This is subtly correct but a brief comment explaining the asymmetry would help future readers.
**`backtrace_suppression_test_cross_kthread` is well-structured:**
```c
+ kunit_warning_suppress(test) {
+ task = kthread_run(cross_kthread_fn, &data, "kunit-cross-test");
+ KUNIT_ASSERT_FALSE(test, IS_ERR(task));
+ wait_for_completion(&data.done);
+ kthread_stop(task);
+ }
+ KUNIT_EXPECT_FALSE(test, data.was_active);
```
The v10 changelog mentions fixing the kthread loop to prevent use-after-free. The test now uses `kthread_should_stop()` + `schedule()` loop in the kthread function and `kthread_stop()` in the test, which is correct.
**`backtrace_suppression_test_multi_scope` tests sequential (not nested) usage:**
```c
+ sw1 = kunit_start_suppress_warning(test);
+ trigger_backtrace_warn_on();
+ WARN(1, "suppressed by sw1");
+ kunit_end_suppress_warning(test, sw1);
+
+ sw2 = kunit_start_suppress_warning(test);
+ WARN(1, "suppressed by sw2");
+ kunit_end_suppress_warning(test, sw2);
```
This validates sequential independent suppression blocks and per-block counts. Good. The count check uses the handles after `end`, which works because the memory is managed by `kunit_kzalloc` (freed at test exit, not at end-of-suppression).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 0:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 11:06 [PATCH v11 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-14 11:06 ` [PATCH v11 1/4] bug/kunit: Core " Albert Esteve
2026-05-15 7:58 ` Albert Esteve
2026-05-16 0:56 ` Claude review: " Claude Code Review Bot
2026-05-14 11:06 ` [PATCH v11 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-15 8:30 ` Albert Esteve
2026-05-16 0:56 ` Claude Code Review Bot [this message]
2026-05-14 11:06 ` [PATCH v11 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-16 0:56 ` Claude review: " Claude Code Review Bot
2026-05-14 11:06 ` [PATCH v11 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-16 0:56 ` Claude review: " Claude Code Review Bot
2026-05-16 0:56 ` Claude review: kunit: Add support for suppressing warning backtraces Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-15 12:29 [PATCH v13 0/4] " Albert Esteve
2026-05-15 12:29 ` [PATCH v13 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
2026-05-15 8:52 [PATCH v12 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-15 8:52 ` [PATCH v12 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-15 23:36 ` Claude review: " Claude Code Review Bot
2026-05-13 7:30 [PATCH v10 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-13 7:30 ` [PATCH v10 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-16 2:29 ` Claude review: " Claude Code Review Bot
2026-05-04 7:41 [PATCH v8 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-04 7:41 ` [PATCH v8 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-04 22:33 ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 [PATCH v7 0/5] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-04-20 12:28 ` [PATCH v7 3/5] kunit: Add backtrace suppression self-tests Albert Esteve
2026-04-22 23:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260514-kunit_add_support-v11-2-b36a530a6d8f@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox