public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: kunit: Add documentation for warning backtrace suppression API
Date: Sat, 16 May 2026 10:56:14 +1000	[thread overview]
Message-ID: <review-patch4-20260514-kunit_add_support-v11-4-b36a530a6d8f@redhat.com> (raw)
In-Reply-To: <20260514-kunit_add_support-v11-4-b36a530a6d8f@redhat.com>

Patch Review

**Overall: Clear and correct documentation.**

The documentation covers both API forms with code examples and includes the important note about checking warning counts inside the scoped block.

**Minor: The doc shows `kunit_suppressed_warning_count(w)` used after `kunit_end_suppress_warning()`:**

```rst
+		w = kunit_start_suppress_warning(test);
+		trigger_backtrace();
+		kunit_end_suppress_warning(test, w);
+
+		KUNIT_EXPECT_EQ(test, kunit_suppressed_warning_count(w), 1);
```

This is valid because `w` remains allocated (via `kunit_kzalloc`) until test exit. But it's worth being explicit in the documentation that `w` remains readable after `kunit_end_suppress_warning` — a reader might assume end-suppress frees the handle. The test code in patch 2 (`backtrace_suppression_test_multi_scope`) relies on this same property, so it's an intentional design choice. A one-line note in the docs like "The handle remains valid for count queries after ``kunit_end_suppress_warning()``" would prevent confusion.

**Fixes missing newline at EOF:**

```diff
-	}
\ No newline at end of file
+	}
```

Nice cleanup.

**Summary:** This is a mature, well-reviewed series at v11. The core design is sound, the test coverage is thorough, and the DRM usage patch is a good practical demonstration. The issues identified are all minor style/documentation nits rather than correctness problems. From the DRM subsystem perspective, patch 3 is a clean improvement to the drm_rect tests.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  0:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 11:06 [PATCH v11 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-14 11:06 ` [PATCH v11 1/4] bug/kunit: Core " Albert Esteve
2026-05-15  7:58   ` Albert Esteve
2026-05-16  0:56   ` Claude review: " Claude Code Review Bot
2026-05-14 11:06 ` [PATCH v11 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-15  8:30   ` Albert Esteve
2026-05-16  0:56   ` Claude review: " Claude Code Review Bot
2026-05-14 11:06 ` [PATCH v11 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-16  0:56   ` Claude review: " Claude Code Review Bot
2026-05-14 11:06 ` [PATCH v11 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-16  0:56   ` Claude Code Review Bot [this message]
2026-05-16  0:56 ` Claude review: kunit: Add support for suppressing warning backtraces Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-15 12:29 [PATCH v13 0/4] " Albert Esteve
2026-05-15 12:29 ` [PATCH v13 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-15 23:18   ` Claude review: " Claude Code Review Bot
2026-05-15  8:52 [PATCH v12 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-15  8:52 ` [PATCH v12 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-15 23:36   ` Claude review: " Claude Code Review Bot
2026-05-13  7:30 [PATCH v10 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-13  7:30 ` [PATCH v10 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-16  2:29   ` Claude review: " Claude Code Review Bot
2026-05-04  7:41 [PATCH v8 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-04  7:41 ` [PATCH v8 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-04 22:33   ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 [PATCH v7 0/5] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-04-20 12:28 ` [PATCH v7 5/5] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-04-22 23:52   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260514-kunit_add_support-v11-4-b36a530a6d8f@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox