public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: kunit: Add documentation for warning backtrace suppression API
Date: Sat, 16 May 2026 09:18:01 +1000	[thread overview]
Message-ID: <review-patch4-20260515-kunit_add_support-v13-4-18ee42f96e7b@redhat.com> (raw)
In-Reply-To: <20260515-kunit_add_support-v13-4-18ee42f96e7b@redhat.com>

Patch Review

The documentation is clear and shows both API forms with examples. 

**Minor nit:** The documentation shows the direct API example checking the warning count *after* `kunit_end_suppress_warning()`:

```rst
+		w = kunit_start_suppress_warning(test);
+		trigger_backtrace();
+		kunit_end_suppress_warning(test, w);
+
+		KUNIT_EXPECT_EQ(test, kunit_suppressed_warning_count(w), 1);
```

This works because the handle memory is managed by `kunit_kzalloc()` and remains valid until test exit — the `end` call only removes the node from the RCU list, it doesn't free the struct. This is an important property that makes the direct API more ergonomic than the scoped form for post-scope count checks. The code comment in patch 1 explains this, and the doc example demonstrates it. Good.

**Also good:** The patch fixes a missing newline at end of file in usage.rst:
```
-	}
\ No newline at end of file
+	}
```

**No issues found.**

---

**Summary:** This is a well-crafted v13 series with solid design, comprehensive tests, and clean code. The RCU + spinlock synchronization is standard kernel practice, the static branch gives zero overhead outside tests, and the `in_task()` guard prevents false suppression from interrupt context. The series has appropriate reviews from KUnit and security maintainers. No blocking issues found from a DRM subsystem perspective; the drm_rect_test changes in patch 3 are clean and correct.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-15 23:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 12:29 [PATCH v13 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-15 12:29 ` [PATCH v13 1/4] bug/kunit: Core " Albert Esteve
2026-05-15 13:36   ` Albert Esteve
2026-05-15 23:18   ` Claude review: " Claude Code Review Bot
2026-05-15 12:29 ` [PATCH v13 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-15 14:14   ` Albert Esteve
2026-05-15 23:18   ` Claude review: " Claude Code Review Bot
2026-05-15 12:29 ` [PATCH v13 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-15 23:18   ` Claude review: " Claude Code Review Bot
2026-05-15 12:29 ` [PATCH v13 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-15 23:18   ` Claude Code Review Bot [this message]
2026-05-15 13:51 ` [PATCH v13 0/4] kunit: Add support for suppressing warning backtraces Guenter Roeck
2026-05-15 14:25   ` Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-15  8:52 [PATCH v12 0/4] " Albert Esteve
2026-05-15  8:52 ` [PATCH v12 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-15 23:36   ` Claude review: " Claude Code Review Bot
2026-05-14 11:06 [PATCH v11 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-14 11:06 ` [PATCH v11 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-16  0:56   ` Claude review: " Claude Code Review Bot
2026-05-13  7:30 [PATCH v10 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-13  7:30 ` [PATCH v10 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-16  2:29   ` Claude review: " Claude Code Review Bot
2026-05-04  7:41 [PATCH v8 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-04  7:41 ` [PATCH v8 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-04 22:33   ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 [PATCH v7 0/5] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-04-20 12:28 ` [PATCH v7 5/5] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-04-22 23:52   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260515-kunit_add_support-v13-4-18ee42f96e7b@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox