From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: kunit: Add support for suppressing warning backtraces
Date: Sat, 16 May 2026 09:18:00 +1000 [thread overview]
Message-ID: <review-overall-20260515-kunit_add_support-v13-0-18ee42f96e7b@redhat.com> (raw)
In-Reply-To: <20260515-kunit_add_support-v13-0-18ee42f96e7b@redhat.com>
Overall Series Review
Subject: kunit: Add support for suppressing warning backtraces
Author: Albert Esteve <aesteve@redhat.com>
Patches: 9
Reviewed: 2026-05-16T09:18:00.257637
---
This is a well-evolved v13 series (originally RFC by Alessandro Carminati, carried forward by Guenter Roeck, now stewarded by Albert Esteve) adding KUnit warning backtrace suppression. The design is solid: task-scoped suppression integrated into the existing KUnit hooks infrastructure, with zero overhead when no tests are running (via the `kunit_running` static branch). The series is cleanly split into infrastructure, tests, a real-world user, and documentation.
**Strengths:**
- Clean integration into existing KUnit hooks — no new config options, no arch-specific code
- Three suppression points covering both `__WARN_FLAGS` and non-`__WARN_FLAGS` architectures
- The `count` parameter to `kunit_is_suppressed_warning()` elegantly solves the double-counting problem
- The `in_task()` guard prevents false suppression from hardirq context
- Good test coverage including cross-kthread isolation
- Scoped API using `__cleanup` attribute is ergonomic
**Concerns (minor):**
- The `synchronize_rcu()` in cleanup path could add measurable latency in test suites with many suppression scopes, though it's correct
- The nesting prohibition (only one active suppression per task) may be limiting for complex test helpers, but is reasonable for v1
Overall this looks ready to merge with the reviews it already has (David Gow, Kees Cook). A few minor observations follow.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-15 23:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 12:29 [PATCH v13 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-15 12:29 ` [PATCH v13 1/4] bug/kunit: Core " Albert Esteve
2026-05-15 13:36 ` Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
2026-05-15 12:29 ` [PATCH v13 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-15 14:14 ` Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
2026-05-15 12:29 ` [PATCH v13 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
2026-05-15 12:29 ` [PATCH v13 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
2026-05-15 13:51 ` [PATCH v13 0/4] kunit: Add support for suppressing warning backtraces Guenter Roeck
2026-05-15 14:25 ` Albert Esteve
2026-05-15 23:18 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-15 8:52 [PATCH v12 " Albert Esteve
2026-05-15 23:36 ` Claude review: " Claude Code Review Bot
2026-05-14 11:06 [PATCH v11 0/4] " Albert Esteve
2026-05-16 0:56 ` Claude review: " Claude Code Review Bot
2026-05-13 7:30 [PATCH v10 0/4] " Albert Esteve
2026-05-16 2:29 ` Claude review: " Claude Code Review Bot
2026-05-04 7:41 [PATCH v8 0/4] " Albert Esteve
2026-05-04 22:33 ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 [PATCH v7 0/5] " Albert Esteve
2026-04-22 23:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260515-kunit_add_support-v13-0-18ee42f96e7b@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox