From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Suppress intentional warning backtraces in scaling unit tests
Date: Sat, 16 May 2026 09:18:01 +1000 [thread overview]
Message-ID: <review-patch3-20260515-kunit_add_support-v13-3-18ee42f96e7b@redhat.com> (raw)
In-Reply-To: <20260515-kunit_add_support-v13-3-18ee42f96e7b@redhat.com>
Patch Review
**Good real-world demonstration of the API.**
```c
+ int expected_warnings = IS_ENABLED(CONFIG_BUG) ?
+ (params->expected_scaling_factor == -EINVAL) : 0;
+ int scaling_factor = INT_MIN;
```
The `INT_MIN` initialization is defensive — if the `kunit_warning_suppress` block fails to set up (returns NULL due to allocation failure), `scaling_factor` retains a sentinel value that won't accidentally match the expected value. The `#include <linux/limits.h>` is added for `INT_MIN`.
The `expected_warnings` computation is clever: on `CONFIG_BUG=n`, WARN_ON is a no-op, so the counter stays zero. On `CONFIG_BUG=y`, warnings fire only for the `-EINVAL` test cases (bad parameters). The boolean-to-int conversion `(params->expected_scaling_factor == -EINVAL)` yields 0 or 1, which is correct.
```c
+ kunit_warning_suppress(test) {
+ scaling_factor = drm_rect_calc_hscale(¶ms->src, ¶ms->dst,
+ params->min_range,
+ params->max_range);
+ KUNIT_EXPECT_SUPPRESSED_WARNING_COUNT(test, expected_warnings);
+ }
KUNIT_EXPECT_EQ(test, scaling_factor, params->expected_scaling_factor);
```
The `KUNIT_EXPECT_EQ` check on `scaling_factor` is correctly placed *outside* the suppress block — it doesn't need suppression and this keeps the suppress scope as narrow as possible. The warning count check is inside the block as required by the API.
**No issues found.**
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-15 23:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 12:29 [PATCH v13 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-15 12:29 ` [PATCH v13 1/4] bug/kunit: Core " Albert Esteve
2026-05-15 13:36 ` Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
2026-05-15 12:29 ` [PATCH v13 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-15 14:14 ` Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
2026-05-15 12:29 ` [PATCH v13 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-15 23:18 ` Claude Code Review Bot [this message]
2026-05-15 12:29 ` [PATCH v13 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
2026-05-15 13:51 ` [PATCH v13 0/4] kunit: Add support for suppressing warning backtraces Guenter Roeck
2026-05-15 14:25 ` Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-15 8:52 [PATCH v12 0/4] " Albert Esteve
2026-05-15 8:52 ` [PATCH v12 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-15 23:36 ` Claude review: " Claude Code Review Bot
2026-05-14 11:06 [PATCH v11 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-14 11:06 ` [PATCH v11 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-16 0:56 ` Claude review: " Claude Code Review Bot
2026-05-13 7:30 [PATCH v10 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-13 7:30 ` [PATCH v10 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-16 2:29 ` Claude review: " Claude Code Review Bot
2026-05-04 7:41 [PATCH v8 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-04 7:41 ` [PATCH v8 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-04 22:33 ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 [PATCH v7 0/5] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-04-20 12:28 ` [PATCH v7 4/5] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-04-22 23:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260515-kunit_add_support-v13-3-18ee42f96e7b@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox