public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Suppress intentional warning backtraces in scaling unit tests
Date: Sat, 16 May 2026 12:29:14 +1000	[thread overview]
Message-ID: <review-patch3-20260513-kunit_add_support-v10-3-e379d206c8cd@redhat.com> (raw)
In-Reply-To: <20260513-kunit_add_support-v10-3-e379d206c8cd@redhat.com>

Patch Review

**Clean practical demonstration.** The changes wrap `drm_rect_calc_hscale()` and `drm_rect_calc_vscale()` calls in `kunit_warning_suppress()` blocks:

```c
int expected_warnings = params->expected_scaling_factor == -EINVAL;
int scaling_factor = INT_MIN;

kunit_warning_suppress(test) {
	scaling_factor = drm_rect_calc_hscale(&params->src, &params->dst,
					      params->min_range,
					      params->max_range);
	KUNIT_EXPECT_SUPPRESSED_WARNING_COUNT(test, expected_warnings);
}
```

The `expected_warnings` calculation (`== -EINVAL` yields 0 or 1) correctly maps the error cases to expected warning counts. Initializing `scaling_factor = INT_MIN` ensures a clearly wrong value if the suppression block is somehow skipped (e.g., allocation failure causes `kunit_start_suppress_warning()` to return NULL → loop body never executes). In that case the subsequent `KUNIT_EXPECT_EQ(test, scaling_factor, ...)` would fail, which is the right behavior.

The `#include <linux/limits.h>` for `INT_MIN` is correct.

**Note:** The suppression wraps *all* parameterized test iterations, not just the `-EINVAL` ones. For non-error cases, `expected_warnings` is 0, so the `KUNIT_EXPECT_SUPPRESSED_WARNING_COUNT` check verifies no spurious warnings. This is a nice property.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  2:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13  7:30 [PATCH v10 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-13  7:30 ` [PATCH v10 1/4] bug/kunit: Core " Albert Esteve
2026-05-16  2:29   ` Claude review: " Claude Code Review Bot
2026-05-13  7:30 ` [PATCH v10 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-16  2:29   ` Claude review: " Claude Code Review Bot
2026-05-13  7:30 ` [PATCH v10 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-16  2:29   ` Claude Code Review Bot [this message]
2026-05-13  7:30 ` [PATCH v10 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-16  2:29   ` Claude review: " Claude Code Review Bot
2026-05-14  8:38 ` [PATCH v10 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-16  2:29 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-15 12:29 [PATCH v13 0/4] " Albert Esteve
2026-05-15 12:29 ` [PATCH v13 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-15 23:18   ` Claude review: " Claude Code Review Bot
2026-05-15  8:52 [PATCH v12 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-15  8:52 ` [PATCH v12 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-15 23:36   ` Claude review: " Claude Code Review Bot
2026-05-14 11:06 [PATCH v11 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-14 11:06 ` [PATCH v11 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-16  0:56   ` Claude review: " Claude Code Review Bot
2026-05-04  7:41 [PATCH v8 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-04  7:41 ` [PATCH v8 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-04 22:33   ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 [PATCH v7 0/5] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-04-20 12:28 ` [PATCH v7 4/5] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-04-22 23:52   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260513-kunit_add_support-v10-3-e379d206c8cd@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox