Claude review: kunit: Add support for suppressing warning backtraces

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: kunit: Add support for suppressing warning backtraces
Author: Albert Esteve <aesteve@redhat.com>
Patches: 6
Reviewed: 2026-05-16T12:29:13.079512

---

This is a well-structured v10 patch series that adds WARN*() backtrace suppression to KUnit. The design is sound: it integrates into the existing KUnit hooks infrastructure for zero overhead when no tests run, uses task-scoped suppression (leveraging KUnit's kthread-per-test model), and provides both scoped and direct API forms. The series has accumulated Reviewed-by from David Gow (KUnit maintainer) and Kees Cook, plus testing tags from LKFT.

**Strengths:**
- Clean integration into existing hooks infrastructure avoids new config options
- Task-scoped suppression is simpler and more robust than the earlier function-name-matching approach
- RCU for readers, spinlock for writers is the correct pattern for this use case
- The scoped API using `__cleanup` with `kunit_add_action()` as a safety net is well-thought-out
- Good test coverage including cross-kthread isolation test
- The `bool count` parameter to avoid double-counting across `__warn_printk()` and `__report_bug()` is a necessary detail handled correctly

**Concerns (minor):**
- The no-nesting restriction (`kunit_has_active_suppress_warning()` check at start) is a deliberate simplification but could limit future use cases where a helper function independently wants suppression
- After `kunit_add_action_or_reset()` fails, the entry has already been added to the RCU list via `list_add_rcu()`, so the `_or_reset` suffix handles cleanup of the `kunit_kzalloc`'d memory, but the list entry was already removed by the reset action — this is correct but subtle

**Overall: This series looks ready to merge. The issues below are minor.**

---

---
Generated by Claude Code Patch Reviewer