From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: kunit: Add backtrace suppression self-tests
Date: Sat, 16 May 2026 12:29:13 +1000 [thread overview]
Message-ID: <review-patch2-20260513-kunit_add_support-v10-2-e379d206c8cd@redhat.com> (raw)
In-Reply-To: <20260513-kunit_add_support-v10-2-e379d206c8cd@redhat.com>
Patch Review
**Good test coverage.** The tests exercise:
- Direct WARN() suppression with count verification
- Indirect WARN() from a called function (marked `noinline` — good, prevents inlining from changing the warning's call site)
- Multiple warnings in one block
- WARN_ON() variants (with appropriate CONFIG_DEBUG_BUGVERBOSE/CONFIG_KALLSYMS skip conditions)
- Incremental counting
- Active-state transitions around suppression boundaries
- Multi-scope using the direct API with sequential independent suppression blocks
- Cross-kthread isolation
**The multi_scope test** validates that after `kunit_end_suppress_warning(test, sw1)`, the handle `sw1` still has valid count data. This works because `kunit_release_action()` removes it from the list and frees the action entry, but the `kunit_kzalloc`'d memory is still live until test teardown. This is subtle but correct — worth noting that `sw1`'s memory outlives the suppression because it's managed by `kunit_kzalloc()` (test-lifetime), not the action.
**Minor nit:** The `backtrace_suppression_test_warn_on_direct` test skips if `!CONFIG_DEBUG_BUGVERBOSE && !CONFIG_KALLSYMS`, while `backtrace_suppression_test_warn_on_indirect` only checks `!CONFIG_DEBUG_BUGVERBOSE`. The asymmetry is because direct WARN_ON() at the call site can use KALLSYMS to resolve the address, but indirect WARN_ON() from a noinline helper needs BUGVERBOSE for file/line info. This seems intentional.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 2:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 7:30 [PATCH v10 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-13 7:30 ` [PATCH v10 1/4] bug/kunit: Core " Albert Esteve
2026-05-16 2:29 ` Claude review: " Claude Code Review Bot
2026-05-13 7:30 ` [PATCH v10 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-16 2:29 ` Claude Code Review Bot [this message]
2026-05-13 7:30 ` [PATCH v10 3/4] drm: Suppress intentional warning backtraces in scaling unit tests Albert Esteve
2026-05-16 2:29 ` Claude review: " Claude Code Review Bot
2026-05-13 7:30 ` [PATCH v10 4/4] kunit: Add documentation for warning backtrace suppression API Albert Esteve
2026-05-16 2:29 ` Claude review: " Claude Code Review Bot
2026-05-14 8:38 ` [PATCH v10 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-16 2:29 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-15 12:29 [PATCH v13 0/4] " Albert Esteve
2026-05-15 12:29 ` [PATCH v13 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-15 23:18 ` Claude review: " Claude Code Review Bot
2026-05-15 8:52 [PATCH v12 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-15 8:52 ` [PATCH v12 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-15 23:36 ` Claude review: " Claude Code Review Bot
2026-05-14 11:06 [PATCH v11 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-14 11:06 ` [PATCH v11 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-16 0:56 ` Claude review: " Claude Code Review Bot
2026-05-04 7:41 [PATCH v8 0/4] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-05-04 7:41 ` [PATCH v8 2/4] kunit: Add backtrace suppression self-tests Albert Esteve
2026-05-04 22:33 ` Claude review: " Claude Code Review Bot
2026-04-20 12:28 [PATCH v7 0/5] kunit: Add support for suppressing warning backtraces Albert Esteve
2026-04-20 12:28 ` [PATCH v7 3/5] kunit: Add backtrace suppression self-tests Albert Esteve
2026-04-22 23:52 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260513-kunit_add_support-v10-2-e379d206c8cd@redhat.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox