From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: sii9234: use dev_err_probe where applicable
Date: Thu, 04 Jun 2026 12:19:46 +1000 [thread overview]
Message-ID: <review-patch2-20260602-exynos4-sii9234-driver-v4-2-9b2fc38e104a@grimler.se> (raw)
In-Reply-To: <20260602-exynos4-sii9234-driver-v4-2-9b2fc38e104a@grimler.se>
Patch Review
**Verdict: Good to go.**
Converts three error paths to use `dev_err_probe()`:
1. GPIO reset acquisition -- was using `IS_ERR` + `dev_err` + return, now uses `dev_err_probe` which correctly handles deferred probe suppression.
2. Regulator bulk get -- was manually checking for `-EPROBE_DEFER` to suppress the message, `dev_err_probe` handles this automatically.
3. IRQ handler request -- was using `dev_err` unconditionally, `dev_err_probe` is better since `devm_request_threaded_irq` can return `-EPROBE_DEFER`.
All three conversions are correct. Net reduction of 5 lines. Reviewed-by from Dmitry is appropriate.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 2:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 18:36 [PATCH RESEND v4 0/3] drm/bridge: sii9234: use extcon to detect cable attachment Henrik Grimler
2026-06-02 18:36 ` [PATCH RESEND v4 1/3] drm/bridge: sii9234: fix some typos in comments and messages Henrik Grimler
2026-06-04 2:19 ` Claude review: " Claude Code Review Bot
2026-06-02 18:36 ` [PATCH RESEND v4 2/3] drm/bridge: sii9234: use dev_err_probe where applicable Henrik Grimler
2026-06-04 2:19 ` Claude Code Review Bot [this message]
2026-06-02 18:36 ` [PATCH RESEND v4 3/3] drm/bridge: sii9234: use extcon cable detection logic to detect MHL Henrik Grimler
2026-06-04 2:19 ` Claude review: " Claude Code Review Bot
2026-06-04 2:19 ` Claude review: drm/bridge: sii9234: use extcon to detect cable attachment Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260602-exynos4-sii9234-driver-v4-2-9b2fc38e104a@grimler.se \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox