public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: types: introduce ForLt base trait for CovariantForLt
Date: Thu, 04 Jun 2026 12:08:39 +1000	[thread overview]
Message-ID: <review-patch2-20260603011020.2073650-3-dakr@kernel.org> (raw)
In-Reply-To: <20260603011020.2073650-3-dakr@kernel.org>

Patch Review

The trait split is well-designed:

```rust
pub trait ForLt {
    type Of<'a>: 'a;
    unsafe fn cast_ref_unchecked<'r, 'short: 'r, 'long: 'short>(...) -> ...;
}

pub unsafe trait CovariantForLt: ForLt {
    fn cast_ref<'r, 'short: 'r, 'long: 'short>(...) -> ...;
}
```

`ForLt` is not `unsafe` to implement (correct — it makes no variance guarantee), while `cast_ref_unchecked` is `unsafe` to call. `CovariantForLt` is `unsafe` to implement (the implementer guarantees covariance) with a safe `cast_ref`.

The `ForLtImpl` helper struct correctly omits the `const N: usize` parameter since no covariance proof needs to be embedded:

```rust
pub struct ForLtImpl<T: ?Sized, WF>(PhantomData<(WF, T)>);
```

The blanket `ForLt` impl on `CovariantForLtImpl` correctly covers all `N`:

```rust
impl<T: ?Sized + for<'a> WithLt<'a>, WF, const N: usize> ForLt for CovariantForLtImpl<T, WF, N> {
    type Of<'a> = <T as WithLt<'a>>::Of;
}
```

This is needed so that `CovariantForLt: ForLt` is satisfied.

The macro refactoring (`resolve_hrt`, `ty_static` shared helpers) is clean. The new `for_lt()` macro function correctly skips the covariance `Prover` pass.

**Minor observation:** `CovariantForLt::cast_ref` still contains its own `transmute` rather than delegating to `unsafe { Self::cast_ref_unchecked(long) }`. This is fine for performance (both are `#[inline(always)]`), but using the unchecked version would make the relationship between the two methods more explicit. Not worth a respin.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  2:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03  1:10 [PATCH v2 0/7] ForLt/CovariantForLt split, auxiliary closure API and DevresLt Danilo Krummrich
2026-06-03  1:10 ` [PATCH v2 1/7] rust: types: rename ForLt to CovariantForLt Danilo Krummrich
2026-06-03 11:59   ` Gary Guo
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-03  1:10 ` [PATCH v2 2/7] rust: types: introduce ForLt base trait for CovariantForLt Danilo Krummrich
2026-06-03 12:04   ` Gary Guo
2026-06-04  2:08   ` Claude Code Review Bot [this message]
2026-06-03  1:10 ` [PATCH v2 3/7] rust: auxiliary: add registration_data_with() for ForLt types Danilo Krummrich
2026-06-03 12:05   ` Gary Guo
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-03  1:10 ` [PATCH v2 4/7] rust: auxiliary: sample: demonstrate ForLt with invariant Mutex type Danilo Krummrich
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-03  1:10 ` [PATCH v2 5/7] rust: devres: add DevresLt for ForLt-aware device resource access Danilo Krummrich
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-03  1:10 ` [PATCH v2 6/7] rust: pci: return DevresLt from Bar::into_devres() Danilo Krummrich
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-03  1:10 ` [PATCH v2 7/7] rust: io: mem: return DevresLt from IoMem/ExclusiveIoMem::into_devres() Danilo Krummrich
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-04  2:08 ` Claude review: ForLt/CovariantForLt split, auxiliary closure API and DevresLt Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260603011020.2073650-3-dakr@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox