From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: io: mem: return DevresLt from IoMem/ExclusiveIoMem::into_devres()
Date: Thu, 04 Jun 2026 12:08:40 +1000 [thread overview]
Message-ID: <review-patch7-20260603011020.2073650-8-dakr@kernel.org> (raw)
In-Reply-To: <20260603011020.2073650-8-dakr@kernel.org>
Patch Review
Same pattern as Patch 6, applied to `IoMem` and `ExclusiveIoMem`. The covariance safety arguments are correct — both types ultimately hold `&'a Device<Bound>`.
The `pwm_th1520.rs` update from `devres::Devres<IoMem<'static, ...>>` to `DevresIoMem<...>` is a clean consumer-side improvement. The driver drops its `devres` import and uses the more specific type alias:
```rust
- iomem: devres::Devres<IoMem<'static, TH1520_PWM_REG_SIZE>>,
+ iomem: DevresIoMem<TH1520_PWM_REG_SIZE>,
```
No issues.
---
**Summary:** Well-structured v2 series with sound safety arguments. The `ForLt`/`CovariantForLt` split, HRTB closure pattern, and `DevresLt` abstraction are all correctly designed. No correctness bugs found. The minor observations above are all non-blocking.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 2:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 1:10 [PATCH v2 0/7] ForLt/CovariantForLt split, auxiliary closure API and DevresLt Danilo Krummrich
2026-06-03 1:10 ` [PATCH v2 1/7] rust: types: rename ForLt to CovariantForLt Danilo Krummrich
2026-06-03 11:59 ` Gary Guo
2026-06-04 2:08 ` Claude review: " Claude Code Review Bot
2026-06-03 1:10 ` [PATCH v2 2/7] rust: types: introduce ForLt base trait for CovariantForLt Danilo Krummrich
2026-06-03 12:04 ` Gary Guo
2026-06-04 2:08 ` Claude review: " Claude Code Review Bot
2026-06-03 1:10 ` [PATCH v2 3/7] rust: auxiliary: add registration_data_with() for ForLt types Danilo Krummrich
2026-06-03 12:05 ` Gary Guo
2026-06-04 2:08 ` Claude review: " Claude Code Review Bot
2026-06-03 1:10 ` [PATCH v2 4/7] rust: auxiliary: sample: demonstrate ForLt with invariant Mutex type Danilo Krummrich
2026-06-04 2:08 ` Claude review: " Claude Code Review Bot
2026-06-03 1:10 ` [PATCH v2 5/7] rust: devres: add DevresLt for ForLt-aware device resource access Danilo Krummrich
2026-06-04 2:08 ` Claude review: " Claude Code Review Bot
2026-06-03 1:10 ` [PATCH v2 6/7] rust: pci: return DevresLt from Bar::into_devres() Danilo Krummrich
2026-06-04 2:08 ` Claude review: " Claude Code Review Bot
2026-06-03 1:10 ` [PATCH v2 7/7] rust: io: mem: return DevresLt from IoMem/ExclusiveIoMem::into_devres() Danilo Krummrich
2026-06-04 2:08 ` Claude Code Review Bot [this message]
2026-06-04 2:08 ` Claude review: ForLt/CovariantForLt split, auxiliary closure API and DevresLt Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch7-20260603011020.2073650-8-dakr@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox