public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: auxiliary: add registration_data_with() for ForLt types
Date: Thu, 04 Jun 2026 12:08:39 +1000	[thread overview]
Message-ID: <review-patch3-20260603011020.2073650-4-dakr@kernel.org> (raw)
In-Reply-To: <20260603011020.2073650-4-dakr@kernel.org>

Patch Review

The private helper extraction is clean:

```rust
unsafe fn registration_data_pinned<F: ForLt + 'static>(&self) -> Result<Pin<&F::Of<'static>>>
```

The `registration_data_with` closure-based API correctly uses an HRTB closure:

```rust
pub fn registration_data_with<F: ForLt + 'static, R>(
    &self,
    f: impl for<'a> FnOnce(Pin<&'a F::Of<'a>>) -> R,
) -> Result<R>
```

The soundness argument is correct: the `for<'a>` quantification prevents the closure from capturing external references with a concrete short lifetime and smuggling them into the invariant type. The round-trip (`'bound` → `'static` → `'a`) is safe because `'a` is universally quantified.

Relaxing `Registration`'s bound from `CovariantForLt` to `ForLt` is the right move — it lets invariant types be registered while `registration_data()` (requiring `CovariantForLt`) remains available as a convenience.

**Minor observation:** The three separate `unsafe` blocks in `registration_data_with` could arguably share a single safety comment since they're all justified by the same HRTB argument. The current form with individual comments is verbose but not wrong.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  2:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03  1:10 [PATCH v2 0/7] ForLt/CovariantForLt split, auxiliary closure API and DevresLt Danilo Krummrich
2026-06-03  1:10 ` [PATCH v2 1/7] rust: types: rename ForLt to CovariantForLt Danilo Krummrich
2026-06-03 11:59   ` Gary Guo
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-03  1:10 ` [PATCH v2 2/7] rust: types: introduce ForLt base trait for CovariantForLt Danilo Krummrich
2026-06-03 12:04   ` Gary Guo
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-03  1:10 ` [PATCH v2 3/7] rust: auxiliary: add registration_data_with() for ForLt types Danilo Krummrich
2026-06-03 12:05   ` Gary Guo
2026-06-04  2:08   ` Claude Code Review Bot [this message]
2026-06-03  1:10 ` [PATCH v2 4/7] rust: auxiliary: sample: demonstrate ForLt with invariant Mutex type Danilo Krummrich
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-03  1:10 ` [PATCH v2 5/7] rust: devres: add DevresLt for ForLt-aware device resource access Danilo Krummrich
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-03  1:10 ` [PATCH v2 6/7] rust: pci: return DevresLt from Bar::into_devres() Danilo Krummrich
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-03  1:10 ` [PATCH v2 7/7] rust: io: mem: return DevresLt from IoMem/ExclusiveIoMem::into_devres() Danilo Krummrich
2026-06-04  2:08   ` Claude review: " Claude Code Review Bot
2026-06-04  2:08 ` Claude review: ForLt/CovariantForLt split, auxiliary closure API and DevresLt Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260603011020.2073650-4-dakr@kernel.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox