From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vc4: Fix a memory leak in hang state error path
Date: Tue, 31 Mar 2026 17:02:00 +1000 [thread overview]
Message-ID: <review-patch3-20260330-vc4-misc-fixes-v1-3-92defc940a29@igalia.com> (raw)
In-Reply-To: <20260330-vc4-misc-fixes-v1-3-92defc940a29@igalia.com>
Patch Review
**Verdict: Good fix.**
Two early returns in `vc4_save_hang_state()` leaked the `kernel_state` allocation. The patch consolidates them into a single `err_free_state` label that unlocks the spinlock and frees `kernel_state`.
```c
-if (!exec[0] && !exec[1]) {
- spin_unlock_irqrestore(&vc4->job_lock, irqflags);
- return;
-}
+if (!exec[0] && !exec[1])
+ goto err_free_state;
```
And:
```c
+err_free_state:
+ spin_unlock_irqrestore(&vc4->job_lock, irqflags);
+ kfree(kernel_state);
```
Both error paths hold the spinlock, and the label correctly releases it before freeing. Note this patch depends on patch 2 being applied first (the `kfree(state->bo)` in `vc4_free_hang_state`), but the second early return (`!kernel_state->bo`) happens before `bo` is allocated, so `kfree(kernel_state)` alone is sufficient at the error label — `kernel_state->bo` is NULL in both error cases (either never assigned, or the allocation failed). Correct.
No issues.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 17:51 [PATCH 0/6] drm/vc4: Miscellaneous fixes and improvements Maíra Canal
2026-03-30 17:51 ` [PATCH 1/6] drm/vc4: Release runtime PM reference after binding V3D Maíra Canal
2026-03-31 7:01 ` Claude review: " Claude Code Review Bot
2026-03-30 17:51 ` [PATCH 2/6] drm/vc4: Fix memory leak of BO array in hang state Maíra Canal
2026-03-31 7:02 ` Claude review: " Claude Code Review Bot
2026-03-30 17:51 ` [PATCH 3/6] drm/vc4: Fix a memory leak in hang state error path Maíra Canal
2026-03-31 7:02 ` Claude Code Review Bot [this message]
2026-03-30 17:51 ` [PATCH 4/6] drm/vc4: Protect madv read in vc4_gem_object_mmap() with madv_lock Maíra Canal
2026-03-31 7:02 ` Claude review: " Claude Code Review Bot
2026-03-30 17:51 ` [PATCH 5/6] drm/vc4: Use devm_request_irq() for automatic cleanup Maíra Canal
2026-03-31 7:02 ` Claude review: " Claude Code Review Bot
2026-03-30 17:51 ` [PATCH 6/6] drm/vc4: Clean-up UAPI header inclusion Maíra Canal
2026-03-31 7:02 ` Claude review: " Claude Code Review Bot
2026-03-31 7:01 ` Claude review: drm/vc4: Miscellaneous fixes and improvements Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260330-vc4-misc-fixes-v1-3-92defc940a29@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox