Claude review: drm/vc4: Use devm_request_irq() for automatic cleanup

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Verdict: Good cleanup, one behavioral note.**

The patch switches from `request_irq()`/`free_irq()` to `devm_request_irq()` and inlines the single-caller `vc4_irq_prepare()`.

**Behavioral change with `!vc4->v3d` check:** The old `vc4_irq_prepare()` would silently return if `!vc4->v3d`. The new code returns `-ENODEV` in that case. This is fine because the caller `vc4_v3d_bind()` only calls `vc4_irq_install()` after successfully setting up `vc4->v3d`, so this path should not be reached in normal operation. The explicit error return is actually better for catching programming errors.

**IRQ name change:** The patch changes the IRQ name from `dev->driver->name` to `dev_name(dev->dev)`. This is a cosmetic difference visible in `/proc/interrupts` but is the idiomatic approach when using devm APIs.

**Removal of `free_irq()` in `vc4_irq_uninstall()`:** Correct since `devm_request_irq()` handles cleanup automatically. The `vc4_irq_disable()` call remains to ensure interrupts are masked before teardown.

**Removed `#include <drm/drm_drv.h>`:** This was only needed for `dev->driver->name` which is no longer used. Fine.

No blocking issues.

---

---
Generated by Claude Code Patch Reviewer