From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vc4: Release runtime PM reference after binding V3D
Date: Tue, 31 Mar 2026 17:01:59 +1000 [thread overview]
Message-ID: <review-patch1-20260330-vc4-misc-fixes-v1-1-92defc940a29@igalia.com> (raw)
In-Reply-To: <20260330-vc4-misc-fixes-v1-1-92defc940a29@igalia.com>
Patch Review
**Verdict: Good fix.**
The `pm_runtime_resume_and_get()` at line 459 acquires a reference that is only released on the error path (`err_put_runtime_pm`) but never on the success path. Adding `pm_runtime_put_autosuspend(dev)` after configuring autosuspend is correct — the device will remain active for the 40ms autosuspend delay and then suspend if no other references are held.
```c
pm_runtime_use_autosuspend(dev);
pm_runtime_set_autosuspend_delay(dev, 40); /* a little over 2 frames. */
+pm_runtime_put_autosuspend(dev);
```
The placement after `pm_runtime_use_autosuspend()` and `pm_runtime_set_autosuspend_delay()` is correct — autosuspend must be configured before calling `put_autosuspend`. Already has Melissa's Reviewed-by.
No issues.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 17:51 [PATCH 0/6] drm/vc4: Miscellaneous fixes and improvements Maíra Canal
2026-03-30 17:51 ` [PATCH 1/6] drm/vc4: Release runtime PM reference after binding V3D Maíra Canal
2026-03-31 7:01 ` Claude Code Review Bot [this message]
2026-03-30 17:51 ` [PATCH 2/6] drm/vc4: Fix memory leak of BO array in hang state Maíra Canal
2026-03-31 7:02 ` Claude review: " Claude Code Review Bot
2026-03-30 17:51 ` [PATCH 3/6] drm/vc4: Fix a memory leak in hang state error path Maíra Canal
2026-03-31 7:02 ` Claude review: " Claude Code Review Bot
2026-03-30 17:51 ` [PATCH 4/6] drm/vc4: Protect madv read in vc4_gem_object_mmap() with madv_lock Maíra Canal
2026-03-31 7:02 ` Claude review: " Claude Code Review Bot
2026-03-30 17:51 ` [PATCH 5/6] drm/vc4: Use devm_request_irq() for automatic cleanup Maíra Canal
2026-03-31 7:02 ` Claude review: " Claude Code Review Bot
2026-03-30 17:51 ` [PATCH 6/6] drm/vc4: Clean-up UAPI header inclusion Maíra Canal
2026-03-31 7:02 ` Claude review: " Claude Code Review Bot
2026-03-31 7:01 ` Claude review: drm/vc4: Miscellaneous fixes and improvements Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260330-vc4-misc-fixes-v1-1-92defc940a29@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox