Claude review: drm/i915/reset: Move pending_fb_pin handling to i915

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

This moves the `pending_fb_pin` atomic counter from `display->restore` to `i915->` (i915-specific) so it's not a display-layer concern. The pending_fb_pin check and wedging are moved from `intel_display_reset_prepare()` into the i915 `intel_gt_reset_global()` caller.

**Issue in `i915_overlay.c`:** The patch adds `atomic_inc(&i915->pending_fb_pin)` before the pin and `atomic_dec(&i915->pending_fb_pin)` after `i915_gem_ww_ctx_fini()`, but critically, the decrement happens **before** checking `if (ret) return ERR_PTR(ret)`:

```c
atomic_inc(&i915->pending_fb_pin);

i915_gem_ww_ctx_init(&ww, true);
retry:
    ...
i915_gem_ww_ctx_fini(&ww);

atomic_dec(&i915->pending_fb_pin);

if (ret)
    return ERR_PTR(ret);
```

On the success path, the counter is decremented immediately after pinning, before the overlay is actually using the pinned buffer. This matches the stated intent ("just cover the actual pinning part") but means the `pending_fb_pin` counter no longer reflects that a framebuffer is actively pinned for display — only that a pin operation is in-flight. The commit message acknowledges this change: "For some reason the overlay code kept the pending_fb_pin counter elevated for longer than just for the pin, but from now on it'll just cover the actual pinning part." This seems intentional but narrows the window where wedging would trigger. Whether that's acceptable depends on the actual deadlock scenario.

**Minor concern in `intel_overlay.c` (display side):** The patch removes the `atomic_inc/dec` pair from the display overlay code (`intel_overlay_do_put_image`), which previously wrapped both the pin call AND the rest of the overlay update. The `out_pin_section` error label is removed. This is fine since the i915-specific `i915_overlay_pin_fb` now handles it internally.

The rest of the `i915_fb_pin.c` and `i915_dpt.c` changes are mechanical s/display->restore.pending_fb_pin/i915->pending_fb_pin/ and look correct.

---
Generated by Claude Code Patch Reviewer