From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe/display: Add init_clock_gating.h stubs
Date: Sun, 12 Apr 2026 12:04:48 +1000 [thread overview]
Message-ID: <review-patch4-20260408233458.22666-5-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260408233458.22666-5-ville.syrjala@linux.intel.com>
Patch Review
Replaces the `#include "../../i915/intel_clock_gating.h"` with proper static inline stubs. This is needed because the next patch will add `intel_display_reset.c` to the xe build, and that file includes `intel_clock_gating.h`.
Also removes the `#ifdef I915` guard from `intel_display_power.c` around the `intel_clock_gating_init()` call, which is now safe because xe has proper stubs.
Clean and correct. Two functions are stubbed: `intel_clock_gating_init()` and `intel_clock_gating_hooks_init()`. Let me verify both are declared in the original header.
The original xe compat header just included the i915 header which would pull in the real declarations. The new stubs provide empty implementations for xe. This is the right approach.
**Looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 2:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 23:34 [PATCH 0/6] drm/i915/reset: Solve display vs. GPU reset deadlock, again Ville Syrjala
2026-04-08 23:34 ` [PATCH 1/6] dma-buf: Remove old lies about dma_fence_wait_any_timeout() not accepting some fences Ville Syrjala
2026-04-09 8:09 ` Jani Nikula
2026-04-09 10:39 ` Christian König
2026-04-12 2:04 ` Claude review: " Claude Code Review Bot
2026-04-08 23:34 ` [PATCH 2/6] drm/i915/reset: Reorganize display reset code Ville Syrjala
2026-04-09 8:13 ` Jani Nikula
2026-04-12 2:04 ` Claude review: " Claude Code Review Bot
2026-04-08 23:34 ` [PATCH 3/6] drm/i915/reset: Move pending_fb_pin handling to i915 Ville Syrjala
2026-04-09 8:17 ` Jani Nikula
2026-04-12 2:04 ` Claude review: " Claude Code Review Bot
2026-04-08 23:34 ` [PATCH 4/6] drm/xe/display: Add init_clock_gating.h stubs Ville Syrjala
2026-04-09 8:19 ` Jani Nikula
2026-04-12 2:04 ` Claude Code Review Bot [this message]
2026-04-08 23:34 ` [PATCH 5/6] drm/i915/reset: Handle the display vs. GPU reset deadlock using a custom dma-fence Ville Syrjala
2026-04-09 10:37 ` Jani Nikula
2026-04-09 10:46 ` Christian König
2026-04-09 11:19 ` Ville Syrjälä
2026-04-09 12:17 ` Christian König
2026-04-12 2:04 ` Claude review: " Claude Code Review Bot
2026-04-08 23:34 ` [PATCH 6/6] drm/i915/display: Make fence timeout infinite Ville Syrjala
2026-04-09 10:51 ` Jani Nikula
2026-04-12 2:04 ` Claude review: " Claude Code Review Bot
2026-04-12 2:04 ` Claude review: drm/i915/reset: Solve display vs. GPU reset deadlock, again Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260408233458.22666-5-ville.syrjala@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox