Claude review: fbdev: goldfishfb: Request memory region

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Status: Good, with one observation**

Converts from bare `ioremap()` to `devm_ioremap_resource()`, and correctly removes the manual `iounmap()` calls from both the error unwind path and `goldfish_fb_remove()`.

```c
fb->reg_base = devm_ioremap_resource(&pdev->dev, r);
if (IS_ERR(fb->reg_base)) {
    ret = PTR_ERR(fb->reg_base);
    goto err_no_io_base;
}
```

**Observation on mapping size:** The original code maps exactly `PAGE_SIZE` bytes:
```c
fb->reg_base = ioremap(r->start, PAGE_SIZE);
```
The new `devm_ioremap_resource()` maps `resource_size(r)` bytes. The actual register space only extends to offset `0x20` (36 bytes), so both PAGE_SIZE and the platform-defined resource size are more than sufficient. Mapping exactly what the resource describes is the right thing to do, so this is a correct change — but it's worth the reviewer being aware that the mapped size is now determined by the platform resource rather than hardcoded.

**Cleanup correctness:** The `iounmap()` removal is safe. The `kfree(fb)` calls in both the error path and `goldfish_fb_remove()` are retained, which is correct — freeing the struct that holds the `reg_base` pointer doesn't conflict with the devm-managed mapping lifetime (the mapping is tied to the device, not the struct).

No issues.

---
Generated by Claude Code Patch Reviewer