public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: clps711x-fb: Request memory region for MMIO
Date: Thu, 23 Apr 2026 09:34:40 +1000	[thread overview]
Message-ID: <review-patch2-20260420134424.77494-3-amit.barzilai22@gmail.com> (raw)
In-Reply-To: <20260420134424.77494-3-amit.barzilai22@gmail.com>

Patch Review

**Status: Good**

Makes resource 0 (MMIO registers) consistent with resource 1 (framebuffer), which already uses `devm_platform_get_and_ioremap_resource()` at line 231 of the current source. Good consistency improvement.

```c
cfb->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(cfb->base)) {
    ret = PTR_ERR(cfb->base);
    goto out_fb_release;
}
```

The original code had a subtle deficiency: when `platform_get_resource()` returned NULL, it jumped to `out_fb_release` with `ret` still at its init value of `-ENOENT` (line 206 of current source). While not a bug per se, the new code is better — `ret` is explicitly set to the actual error from the helper.

`res` is still used afterward (lines 228-229: `info->fix.mmio_start = res->start; info->fix.mmio_len = resource_size(res)`), and it's correctly populated by the `&res` output parameter.

No issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-22 23:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 13:44 [PATCH 0/3] fbdev: Request memory regions in platform drivers Amit Barzilai
2026-04-20 13:44 ` [PATCH 1/3] fbdev: cobalt_lcdfb: Request memory region Amit Barzilai
2026-04-22 14:50   ` Helge Deller
2026-04-22 23:34   ` Claude review: " Claude Code Review Bot
2026-04-20 13:44 ` [PATCH 2/3] fbdev: clps711x-fb: Request memory region for MMIO Amit Barzilai
2026-04-22 23:34   ` Claude Code Review Bot [this message]
2026-04-20 13:44 ` [PATCH 3/3] fbdev: goldfishfb: Request memory region Amit Barzilai
2026-04-22 14:43   ` Helge Deller
2026-04-22 23:34   ` Claude review: " Claude Code Review Bot
2026-04-22 23:34 ` Claude review: fbdev: Request memory regions in platform drivers Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260420134424.77494-3-amit.barzilai22@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox