From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: cobalt_lcdfb: Request memory region
Date: Thu, 23 Apr 2026 09:34:40 +1000 [thread overview]
Message-ID: <review-patch1-20260420134424.77494-2-amit.barzilai22@gmail.com> (raw)
In-Reply-To: <20260420134424.77494-2-amit.barzilai22@gmail.com>
Patch Review
**Status: Good**
Replaces separate `platform_get_resource()` + `devm_ioremap()` with a single `devm_platform_get_and_ioremap_resource()` call. The conversion is correct:
```c
info->screen_base = devm_platform_get_and_ioremap_resource(dev, 0, &res);
if (IS_ERR(info->screen_base)) {
framebuffer_release(info);
return PTR_ERR(info->screen_base);
}
```
The `res` output parameter is correctly used on the following line (`info->screen_size = resource_size(res)`), and the reordering (screen_base assigned before screen_size) is fine since `screen_size` is not needed for the mapping itself.
The original code returned `-EBUSY` when the resource wasn't found, which was arguably the wrong error code. The new code will return the actual error from the helper (likely `-EINVAL`), which is a minor improvement.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 23:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 13:44 [PATCH 0/3] fbdev: Request memory regions in platform drivers Amit Barzilai
2026-04-20 13:44 ` [PATCH 1/3] fbdev: cobalt_lcdfb: Request memory region Amit Barzilai
2026-04-22 14:50 ` Helge Deller
2026-04-22 23:34 ` Claude Code Review Bot [this message]
2026-04-20 13:44 ` [PATCH 2/3] fbdev: clps711x-fb: Request memory region for MMIO Amit Barzilai
2026-04-22 23:34 ` Claude review: " Claude Code Review Bot
2026-04-20 13:44 ` [PATCH 3/3] fbdev: goldfishfb: Request memory region Amit Barzilai
2026-04-22 14:43 ` Helge Deller
2026-04-22 23:34 ` Claude review: " Claude Code Review Bot
2026-04-22 23:34 ` Claude review: fbdev: Request memory regions in platform drivers Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260420134424.77494-2-amit.barzilai22@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox