From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: use a separate helper to translate degamma curves
Date: Thu, 07 May 2026 13:11:57 +1000 [thread overview]
Message-ID: <review-patch3-20260506191606.15022-4-mwen@igalia.com> (raw)
In-Reply-To: <20260506191606.15022-4-mwen@igalia.com>
Patch Review
**Purpose**: Wires up the degamma-specific helper from patch 2 for the blend TF and input (degamma) TF paths in `dcn32_hwseq.c`.
The change is minimal and correct. Two call sites are updated:
1. **Blend TF** (line 493→): `cm3_helper_translate_curve_to_hw_format` → `cm3_helper_translate_curve_to_degamma_hw_format` for `TF_TYPE_DISTRIBUTED_POINTS` blend curves. The degamma helper doesn't take a `dc_context` or `fixpoint` parameter, which is fine — it doesn't need them.
2. **Input TF / degamma** (line 553→): Same substitution for `in_transfer_func`.
**Observation**: The shaper path (around line 516 in the unmodified code) is intentionally left using `cm3_helper_translate_curve_to_hw_format`, since shapers are pre-3DLUT (linear→encoded) and need the regamma-style segmentation. This matches the cover letter's design.
**No issues found.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-07 3:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 19:11 [PATCH v2 0/5] better LUT segmentation for EOTFs Melissa Wen
2026-05-06 19:11 ` [PATCH v2 1/5] drm/amd/display: use GAMCOR for degamma private props in subsampled format Melissa Wen
2026-05-07 3:11 ` Claude review: " Claude Code Review Bot
2026-05-06 19:11 ` [PATCH v2 2/5] Revert "drm/amd/display: Remove unused cm3_helper_translate_curve_to_degamma_hw_format" Melissa Wen
2026-05-07 3:11 ` Claude review: " Claude Code Review Bot
2026-05-06 19:11 ` [PATCH v2 3/5] drm/amd/display: use a separate helper to translate degamma curves Melissa Wen
2026-05-07 3:11 ` Claude Code Review Bot [this message]
2026-05-06 19:11 ` [PATCH v2 4/5] drm/amd/display: support up to 256 samples per region in degamma/blend LUT Melissa Wen
2026-05-07 3:11 ` Claude review: " Claude Code Review Bot
2026-05-06 19:11 ` [PATCH v2 5/5] drm/amd/display: use halving distribution for PQ/sRGB linearizing LUT Melissa Wen
2026-05-07 3:11 ` Claude review: " Claude Code Review Bot
2026-05-07 3:11 ` Claude review: better LUT segmentation for EOTFs Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260506191606.15022-4-mwen@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox