public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support
Date: Sat, 16 May 2026 13:13:42 +1000	[thread overview]
Message-ID: <review-patch3-20260512144104.761531-4-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20260512144104.761531-4-prabhakar.mahadev-lad.rj@bp.renesas.com>

Patch Review

**Status: Acceptable, minor concern.**

The change is a one-liner:

```c
-	rcrtc->rstc = devm_reset_control_get_shared(rcdu->dev, NULL);
+	rcrtc->rstc = devm_reset_control_get_optional_shared(rcdu->dev, NULL);
```

This is the right approach for RZ/T2H which has no reset line. However, `devm_reset_control_get_optional_shared()` returns `NULL` (not an error) when no reset is specified in DT. The existing callers `reset_control_deassert(rcrtc->rstc)` and `reset_control_assert(rcrtc->rstc)` (in `rzg2l_du_crtc_get` at ~line 190 and `rzg2l_du_crtc_put` at line 210) are safe because the reset control API accepts `NULL` and treats it as a no-op. So this is correct.

**Minor concern:** By making the reset universally optional in the driver, a misconfigured DT for RZ/G2L/G2UL (which *does* require a reset) would silently succeed at probe time rather than failing early. The DT binding schema should catch this, but the driver loses its own defensive check. This is an acceptable tradeoff given that the binding enforces `resets` for non-RZ/T2H SoCs, and Laurent has already reviewed this.

Has Reviewed-by from Laurent Pinchart.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  3:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 14:40 [PATCH v3 0/5] Add DU support for RZ/T2H and RZ/N2H SoCs Prabhakar
2026-05-12 14:41 ` [PATCH v3 1/5] dt-bindings: display: renesas, rzg2l-du: Refuse port@1 for RZ/G2UL Prabhakar
2026-05-14 13:20   ` [PATCH v3 1/5] dt-bindings: display: renesas,rzg2l-du: " Rob Herring (Arm)
2026-05-16  3:13   ` Claude review: dt-bindings: display: renesas, rzg2l-du: " Claude Code Review Bot
2026-05-12 14:41 ` [PATCH v3 2/5] dt-bindings: display: renesas, rzg2l-du: Add RZ/T2H and RZ/N2H support Prabhakar
2026-05-14 15:23   ` [PATCH v3 2/5] dt-bindings: display: renesas,rzg2l-du: " Rob Herring (Arm)
2026-05-16  3:13   ` Claude review: dt-bindings: display: renesas, rzg2l-du: " Claude Code Review Bot
2026-05-12 14:41 ` [PATCH v3 3/5] drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Prabhakar
2026-05-16  3:13   ` Claude Code Review Bot [this message]
2026-05-12 14:41 ` [PATCH v3 4/5] drm: renesas: rz-du: Move mode_valid logic to per-output clock limits Prabhakar
2026-05-13 23:02   ` Laurent Pinchart
2026-05-14 12:56     ` Lad, Prabhakar
2026-05-16  3:13   ` Claude review: " Claude Code Review Bot
2026-05-12 14:41 ` [PATCH v3 5/5] drm: renesas: rz-du: Add support for RZ/T2H SoC Prabhakar
2026-05-16  3:13   ` Claude review: " Claude Code Review Bot
2026-05-16  3:13 ` Claude review: Add DU support for RZ/T2H and RZ/N2H SoCs Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-29 17:00 [PATCH 0/4] " Prabhakar
2026-04-29 17:00 ` [PATCH 2/4] drm: renesas: rz-du: Make DU reset control optional for RZ/T2H support Prabhakar
2026-05-05  1:22   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260512144104.761531-4-prabhakar.mahadev-lad.rj@bp.renesas.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox